Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Files instead of FileItems #904

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Use Files instead of FileItems #904

wants to merge 4 commits into from

Commits on Nov 6, 2024

  1. Convert FileItems to Files before using 

    We use Apache FileUpload to assist with handling incoming files. We also use a DiskItemFactory that persists each incoming file to disk immediately. This means that we could represent each incoming file as a java.io.File instead of a FileItem. java.io.File is a much more common way of handling a file and easier to work with.
    @trevorgerhardt
    trevorgerhardt committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    17f33c7 View commit details
    Browse the repository at this point in the history

  2. Set the status before returning the error

    @trevorgerhardt
    trevorgerhardt committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9478914 View commit details
    Browse the repository at this point in the history

  3. Move files into a scratch directory before processing

    @trevorgerhardt
    trevorgerhardt committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b93c733 View commit details
    Browse the repository at this point in the history

  4. Fix NPE from incorrectly re-naming local variable

    @trevorgerhardt
    trevorgerhardt committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    b0e72e4 View commit details
    Browse the repository at this point in the history