-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list indents #116
Fix list indents #116
Conversation
Can you add a test case along with a before/after example? |
This is also failing the existing test cases:
|
Sorry, I didn't notice you had tests. Note that this pr slightly changes the rendering of all list types (unordered, ordered, definition), so while I can update the test cases, you should check if you're happy with the new rendering. Basically, now all of these use an indent of 5. From this input: test
====
text
**Term**
: Def Autem repellendus recusandae sint deserunt non. Quas maxime delectus
suscipit quis facere doloribus. Rerum omnis provident unde non sapiente
magni.
**Long term**
: Long definition
Multiple paragraphs
- including
- lists
: Second definition
more text
1. ordered lists
Also multiple paragraphs
2. second item
- with
- nested
Unordered second paragraph
- item
Another here
3. third Current master generates:
This PR:
If this is ok, I'll just update the tests to match current rendering. |
Hmm, were there no tests for regular lists before? |
6b479c8
to
f615bd3
Compare
It's possible there weren't tests specifically for it. |
Indent all lists a uniform amount, and also support items with multiple paragraphs.
f615bd3
to
0e02fa0
Compare
Oops, didn't know it had to be formatted. Updated the PR. |
Indent all lists a uniform amount, and also support items with multiple paragraphs.
Fixes #107