Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SplitButton): Add node resolve back into the rollup config #4639

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

mcwinter07
Copy link
Contributor

@mcwinter07 mcwinter07 commented Apr 15, 2024

Why

As of release 1.42.3 the SplitButton styles have cause visual regression in consuming repos. This appears to have been caused by the recent update to the Rollup config, whereby the compile CSS is causing the BaseButton styles to override the DropdownButton. It appears that this may have been caused by the removal of rollup pluginplugin-node-resolve, which impact where in the cascade the styles are declared.

Visual regression

image

Dist comparison

@kaizen/components v1.42.3
The BaseButton styles will supersede the DropdownButton

Screenshot 2024-04-15 at 1 45 33 pm (3)
Screenshot 2024-04-15 at 1 45 52 pm (3)

@kaizen/components v1.42.1
The DropdownButton styles will supersede the BaseButton

Screenshot 2024-04-15 at 1 43 23 pm (1)
Screenshot 2024-04-15 at 1 43 08 pm (1)

What

  • Adds the resolve config back into rollup with a comment explaining why it is there... for now

More context

See thread

@mcwinter07 mcwinter07 requested a review from a team as a code owner April 15, 2024 07:34
Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: f5597ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 15, 2024

✨ Here is your branch preview! ✨

Last updated for commit f5597ee: add changeset

@mcwinter07 mcwinter07 merged commit b62ece9 into main Apr 16, 2024
18 checks passed
@mcwinter07 mcwinter07 deleted the KZN-2263/split-button-build-issue branch April 16, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants