fix(SplitButton): Add node resolve back into the rollup config #4639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As of release
1.42.3
the SplitButton styles have cause visual regression in consuming repos. This appears to have been caused by the recent update to the Rollup config, whereby the compile CSS is causing the BaseButton styles to override the DropdownButton. It appears that this may have been caused by the removal of rollup pluginplugin-node-resolve
, which impact where in the cascade the styles are declared.Visual regression
Dist comparison
@kaizen/components v1.42.3
The
BaseButton
styles will supersede theDropdownButton
@kaizen/components v1.42.1
The
DropdownButton
styles will supersede theBaseButton
What
More context
See thread