Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SplitButton): Add node resolve back into the rollup config #4639

Merged
merged 2 commits into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/odd-roses-punch.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@kaizen/components": patch
---

Update rollup config to re-add node resolver
1 change: 1 addition & 0 deletions packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
"@kaizen/design-tokens": "workspace:*",
"@kaizen/tailwind": "workspace:*",
"@rollup/plugin-alias": "^5.1.0",
"@rollup/plugin-node-resolve": "^15.2.3",
"@rollup/plugin-babel": "^6.0.4",
"@rollup/plugin-commonjs": "^25.0.7",
"@rollup/plugin-typescript": "^11.1.6",
Expand Down
11 changes: 11 additions & 0 deletions packages/components/rollup.config.mjs
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import alias from "@rollup/plugin-alias"
import { babel, getBabelOutputPlugin } from "@rollup/plugin-babel";
import commonjs from "@rollup/plugin-commonjs"
import resolve from "@rollup/plugin-node-resolve"
import typescript from "@rollup/plugin-typescript"
import ignore from "rollup-plugin-ignore"
import nodeExternals from "rollup-plugin-node-externals"
import postcss from "rollup-plugin-postcss"


const sharedConfig = {
input: { index: "./src/index.ts", future: "./src/__future__/index.ts" },
plugins: [
Expand All @@ -27,6 +29,15 @@ const sharedConfig = {
},
],
}),
resolve({
preferBuiltins: true,
extensions: [".js", ".jsx", ".ts", ".tsx"
// This is needed to ensure that css is compiled correctly.
// Without this there is an alphabetised order in the dist CSS for subcomponents.
// This can cause styles being overwritten by primitives, ie: BaseButton overwriting DropdownButton
// https://cultureamp.slack.com/archives/C02NUQ27G56/p1713157055178419
],
}),
// These libraries aren't used in KAIO, and require polyfills to be set up
// in consuming repos. Ignoring them here removes the need for extra setup in
// consuming repos.
Expand Down
41 changes: 41 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading