Increment default python version to 3.11 #160
Conversation
gitlab/serverless-legacy-ci.yml
Outdated
| @@ -40,7 +40,7 @@ build-image: | |||
| before_script: | |||
| - echo $AWS_ECR_PASSWORD | docker login --username $AWS_ECR_USERNAME --password-stdin $REGISTRY_URL | |||
| script: | |||
| - echo "FROM python:3.8-slim" > $DAGSTER_CLOUD_LOCATION_DIR/Dockerfile | |||
| - echo "FROM python:3.11-slim" > $DAGSTER_CLOUD_LOCATION_DIR/Dockerfile | |||
There was a problem hiding this comment.
Given the name, I'm not sure if we should be touching this one?
|
Your pull request is automatically being deployed to Dagster Cloud.
|
There was a problem hiding this comment.
As per discussion on slack i think this would require a v0.2 release
we should also update the build/release instructions to clarify that it needs to be done from a 3.11 venv (it currently needs to be done from a 3.8 venv or the resulting built hybrid CI action fails)
|
I think we want to change only the templates that get copied into the user repo. Eg https://github.com/dagster-io/dagster-cloud-action/tree/main/github/serverless |
I suspect we'll want to sufficiently increment the released version so this doesn't break users who are pinned to 0.1.
jmsanders
force-pushed
the
jordan/increment-default-python-version
branch
from
15f5c5e to
18e68f8
Compare
|
So keep all the defaults as 3.8 but have all the user templates override to 3.11? It looks like we might need to add a python_version override to the gitlab templates in that case. |
This reverts commit 18e68f8.
These yaml files actually get copied into user repos and can already pass an overridden python version into our action. If we bump the defaults in the action, we need to introduce a new tag > 0.1 to avoid introducing a breaking change for anybody who is pinned to 0.1 (onto to mention anybody who isn't pinned at all).
|
I don't plan on doing anything with this right now. |
I suspect we'll want to sufficiently increment the released version so this doesn't break users who are pinned to 0.1.