Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment default python version to 3.11 #160

Closed
wants to merge 4 commits into from
Closed

Increment default python version to 3.11 #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18e68f8
Increment default python version to 3.11
jmsanders Mar 27, 2024
c7855c7
Revert "Increment default python version to 3.11"
jmsanders Mar 27, 2024
09f1ac2
Bump to py3.11 in the GH templates, not the action
jmsanders Mar 27, 2024
055a9f8
Also pass python_version through GL action
jmsanders Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github/serverless/branch_deployments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
ENABLE_FAST_DEPLOYS: 'true'
PYTHON_VERSION: '3.8'
PYTHON_VERSION: '3.11'
DAGSTER_CLOUD_FILE: 'dagster_cloud.yaml'

jobs:
Expand Down
2 changes: 1 addition & 1 deletion github/serverless/dbt/branch_deployments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
ENABLE_FAST_DEPLOYS: 'true'
PYTHON_VERSION: '3.8'
PYTHON_VERSION: '3.11'
DAGSTER_CLOUD_FILE: 'dagster_cloud.yaml'

jobs:
Expand Down
2 changes: 1 addition & 1 deletion github/serverless/dbt/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
ENABLE_FAST_DEPLOYS: 'true'
PYTHON_VERSION: '3.8'
PYTHON_VERSION: '3.11'
DAGSTER_CLOUD_FILE: 'dagster_cloud.yaml'

jobs:
Expand Down
2 changes: 1 addition & 1 deletion github/serverless/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
DAGSTER_CLOUD_URL: ${{ secrets.DAGSTER_CLOUD_URL }}
DAGSTER_CLOUD_API_TOKEN: ${{ secrets.DAGSTER_CLOUD_API_TOKEN }}
ENABLE_FAST_DEPLOYS: 'true'
PYTHON_VERSION: '3.8'
PYTHON_VERSION: '3.11'
DAGSTER_CLOUD_FILE: 'dagster_cloud.yaml'

jobs:
Expand Down
1 change: 1 addition & 0 deletions gitlab/dbt/serverless-ci-dbt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ variables:
DAGSTER_DBT_PROJECT_NAME: $DAGSTER_DBT_LOCATION_NAME
DAGSTER_DBT_PROJECT_DIR: "${CI_PROJECT_DIR}"
DAGSTER_DBT_PACKAGE_DATA_DIR: "${CI_PROJECT_DIR}/$DAGSTER_DBT_PROJECT_NAME/dbt-project"
PYTHON_VERSION: "3.11"

deploy-branch:
stage: deploy
Expand Down
2 changes: 2 additions & 0 deletions gitlab/hybrid-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ variables:

# Internally used directory name for build state
DAGSTER_BUILD_STATEDIR: build-state

PYTHON_VERSION: "3.11"
stages:
- setup
- build
Expand Down
1 change: 1 addition & 0 deletions gitlab/serverless-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ variables:
DISABLE_FAST_DEPLOYS:
DAGSTER_CLOUD_URL: $DAGSTER_CLOUD_URL
DAGSTER_CLOUD_API_TOKEN: $DAGSTER_CLOUD_API_TOKEN
PYTHON_VERSION: "3.11"

deploy-branch:
stage: deploy
Expand Down
2 changes: 2 additions & 0 deletions src/gitlab_action/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def deploy(dagster_cloud_yaml_file, deployment=None):
project_url = os.getenv("CI_PROJECT_URL")
commit = os.getenv("CI_COMMIT_SHORT_SHA")
branch = os.getenv("CI_COMMIT_BRANCH") or os.getenv("CI_COMMIT_REF_NAME")
python_version = os.getenv("PYTHON_VERSION")

deps_cache = project + "/" + branch
commit_url = project_url + "/commit/" + commit
Expand All @@ -39,6 +40,7 @@ def deploy(dagster_cloud_yaml_file, deployment=None):
f"--deps-cache-to={deps_cache}",
f"--commit-hash={commit}",
f"--git-url={commit_url}",
f"--python-version={python_version}"
]
if deployment:
command_args.append(f"--url={url}/{deployment}")
Expand Down
Loading