Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serverless workflow template #187

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Update serverless workflow template #187

merged 3 commits into from
Jul 29, 2024

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Jul 15, 2024 •
edited
Loading

Summary

Updates the serverless github actions workflow template to use the CI CLI.

Still need to update the dbt equivalent, will do so in a stacked PR.

Test Plan

Updated https://github.com/dagster-io/dagster-cloud-action-test to match.
Tested NUX flow locally using test GitHub app, successfully deployed code using new action.

@benpankow benpankow requested a review from shalabhc July 15, 2024 19:20
@benpankow
Copy link
Member Author

benpankow commented Jul 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Jul 29, 2024 at 07:45 PM (UTC)

@github-actions GitHub Actions
Copy link

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action Building... Jul 15, 2024 at 07:22 PM (UTC)

@benpankow benpankow mentioned this pull request Jul 15, 2024
Open
@benpankow benpankow force-pushed the benpankow/update-serverless-template branch from deeb0ff to cf3aa2d Compare July 15, 2024 23:01
@benpankow benpankow mentioned this pull request Jul 15, 2024
Draft
shalabhc
shalabhc reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@shalabhc shalabhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These apply to the dbt workflow too.

github/serverless/deploy.yml Outdated Show resolved Hide resolved
github/serverless/deploy.yml Outdated
DAGSTER_CLOUD_FILE: 'dagster_cloud.yaml'
DAGSTER_CLOUD_ORGANIZATION: ${{ secrets.DAGSTER_CLOUD_ORGANIZATION }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're adding this, we should remove DAGSTER_CLOUD_URL which is just duplicative.

https://github.com/dagster-io/dagster-cloud-hybrid-quickstart/blob/main/.github/workflows/dagster-cloud-deploy.yml only uses the org env.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break functionality on non-prod tiers, right? (e.g. dogfooding, canary). I'm hesitant to remove for this reason - we don't have a hybrid quickstart UI flow so less pressing

github/serverless/deploy.yml Outdated Show resolved Hide resolved
@shalabhc shalabhc self-requested a review July 16, 2024 17:17
shalabhc
shalabhc approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@shalabhc shalabhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor comments

@erinkcochran87 erinkcochran87 mentioned this pull request Jul 16, 2024
Closed
@benpankow benpankow merged commit 64e783e into main Jul 29, 2024
7 of 9 checks passed
@benpankow benpankow deleted the benpankow/update-serverless-template branch July 29, 2024 22:57
gibsondan added a commit that referenced this pull request Aug 28, 2024
@gibsondan
Revert "Update serverless workflow template (#187)"
c991977 
This reverts commit 64e783e.
gibsondan added a commit that referenced this pull request Sep 3, 2024
@gibsondan
Revert "Update serverless workflow template (#187)"
084f709 
This reverts commit 64e783e.
gibsondan added a commit that referenced this pull request Oct 28, 2024
@gibsondan
Revert "Update serverless workflow template (#187)"
960c226 
This reverts commit 64e783e.
@gibsondan gibsondan mentioned this pull request Oct 28, 2024
Merged
gibsondan added a commit that referenced this pull request Oct 28, 2024
@gibsondan
Revert "Update serverless workflow template (#187)"
02f57fd 
This reverts commit 64e783e.
gibsondan added a commit that referenced this pull request Oct 30, 2024
@gibsondan
Revert moving default serverless template to new ci, make old serverl…
3d47d05 
…ess template deploy to 3.10 and ubuntu-22.04 (#205)

* Revert "Fix typo in serverless deploy yaml (#204)"

This reverts commit 16278a2.

* Revert "Update serverless workflow template (#187)"

This reverts commit 64e783e.

* Move to 3.10 and ubuntu-22.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalabhc shalabhc shalabhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benpankow @shalabhc