Skip to content

Commit

Permalink
Revert "revert single implicit asset job (#23607)" (#23777)
Browse files Browse the repository at this point in the history
This reverts commit 35f00aa.

## Summary & Motivation

We had reverted the single implicit asset job stack after discovering
that it caused problems in the UI. Those problems are fixed by the stack
ending in [this GraphQL
change](#23494) and [this
frontend change](#23747).

So this unreverts. It shouldn't be merged until that frontend change
makes it in.

## How I Tested These Changes
  • Loading branch information
sryza authored Aug 21, 2024
1 parent d2d1bd6 commit 2616f6d
Show file tree
Hide file tree
Showing 32 changed files with 26,700 additions and 61,910 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ def test_databricks_asset(databricks_client, capsys):
script_file=script_file,
dbfs_path="dbfs:/my_python_script.py",
) as script_file:
job_def = databricks_asset_defs.get_implicit_job_def_for_assets(
[AssetKey("databricks_asset")],
)
job_def = databricks_asset_defs.get_implicit_global_asset_job_def()
assert job_def
result = job_def.execute_in_process()
assert result.success
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
_check as check,
)
from dagster._core.definitions.asset_graph_differ import AssetDefinitionChangeType, AssetGraphDiffer
from dagster._core.definitions.asset_job import ASSET_BASE_JOB_PREFIX
from dagster._core.definitions.asset_job import IMPLICIT_ASSET_JOB_NAME
from dagster._core.definitions.data_time import CachingDataTimeResolver
from dagster._core.definitions.data_version import (
NULL_DATA_VERSION,
Expand Down Expand Up @@ -951,7 +951,7 @@ def resolve_targetingInstigators(self, graphene_info) -> Sequence[GrapheneSensor
job_names = {
job_name
for job_name in self._external_asset_node.job_names
if not job_name.startswith(ASSET_BASE_JOB_PREFIX)
if not job_name == IMPLICIT_ASSET_JOB_NAME
}

results = []
Expand Down
Loading

1 comment on commit 2616f6d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-83rneynld-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit 2616f6d.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.