Skip to content

Commit

Permalink
[ui] Split AssetNodeOverview into sub-components (#25956)
Browse files Browse the repository at this point in the history
The AssetNodeOverview component was approaching 1000 LOC and assembles a
lot of metadata, etc. at the top that is far from where it’s rendered.
This PR doesn’t contain any logic changes, I just broke the file up so
that the metadata being pulled out of the props is closer to where it’s
used and the whole thing is a bit easier to grok.

Co-authored-by: bengotow <[email protected]>
  • Loading branch information
bengotow and bengotow authored Nov 17, 2024
1 parent dc06f80 commit 75dc7ae
Show file tree
Hide file tree
Showing 8 changed files with 1,004 additions and 927 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import {AssetFeatureContext} from './AssetFeatureContext';
import {ASSET_NODE_DEFINITION_FRAGMENT, AssetNodeDefinition} from './AssetNodeDefinition';
import {ASSET_NODE_INSTIGATORS_FRAGMENT} from './AssetNodeInstigatorTag';
import {AssetNodeLineage} from './AssetNodeLineage';
import {AssetNodeOverview, AssetNodeOverviewNonSDA} from './AssetNodeOverview';
import {AssetPartitions} from './AssetPartitions';
import {AssetPlotsPage} from './AssetPlotsPage';
import {AssetTabs} from './AssetTabs';
Expand All @@ -22,8 +21,8 @@ import {LaunchAssetExecutionButton} from './LaunchAssetExecutionButton';
import {UNDERLYING_OPS_ASSET_NODE_FRAGMENT} from './UnderlyingOpsOrGraph';
import {AssetChecks} from './asset-checks/AssetChecks';
import {assetDetailsPathForKey} from './assetDetailsPathForKey';
import {AssetNodeOverview, AssetNodeOverviewNonSDA} from './overview/AssetNodeOverview';
import {AssetKey, AssetViewParams} from './types';
import {AssetTableDefinitionFragment} from './types/AssetTableFragment.types';
import {
AssetViewDefinitionNodeFragment,
AssetViewDefinitionQuery,
Expand All @@ -34,6 +33,7 @@ import {healthRefreshHintFromLiveData} from './usePartitionHealthData';
import {useReportEventsModal} from './useReportEventsModal';
import {useWipeModal} from './useWipeModal';
import {gql, useQuery} from '../apollo-client';
import {AssetTableDefinitionFragment} from './types/AssetTableFragment.types';
import {currentPageAtom} from '../app/analytics';
import {Timestamp} from '../app/time/Timestamp';
import {AssetLiveDataRefreshButton, useAssetLiveData} from '../asset-data/AssetLiveDataProvider';
Expand Down
Loading

1 comment on commit 75dc7ae

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-nq0mtgsp7-elementl.vercel.app

Built with commit 75dc7ae.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.