-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Split AssetNodeOverview into sub-components (#25956)
The AssetNodeOverview component was approaching 1000 LOC and assembles a lot of metadata, etc. at the top that is far from where it’s rendered. This PR doesn’t contain any logic changes, I just broke the file up so that the metadata being pulled out of the props is closer to where it’s used and the whole thing is a bit easier to grok. Co-authored-by: bengotow <[email protected]>
- Loading branch information
Showing
8 changed files
with
1,004 additions
and
927 deletions.
There are no files selected for viewing
925 changes: 0 additions & 925 deletions
925
js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeOverview.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
75dc7ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-nq0mtgsp7-elementl.vercel.app
Built with commit 75dc7ae.
This pull request is being automatically deployed with vercel-action