Change schedule context to use DualStateContextResourcesContainer #16001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 21, 2023
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
eec894b to
627213e
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
c30f584 to
6585362
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
627213e to
f1c9d40
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
6585362 to
1fca729
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
f1c9d40 to
db2725f
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
2 times, most recently
from
a6fb7b4 to
c447fdc
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
0cced75 to
d229be1
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
ec28fe0 to
eb78d2a
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
d229be1 to
f34e0e5
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
eb78d2a to
1065a2a
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
f34e0e5 to
29c4385
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
81ad682 to
a4cb91c
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
29c4385 to
bed3ec1
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
a4cb91c to
94fa794
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
bed3ec1 to
7b8b611
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
94fa794 to
5e7752f
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
7b8b611 to
eb6b06d
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
5e7752f to
a147dcd
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-7
branch
from
eb6b06d to
8883d37
Compare
schrockn
force-pushed
the
cleanup-dual-state-context-8
branch
from
a147dcd to
5a60a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Change Schedule context to use DualStateContextResourcesContainer
This also changes DualStateContextResourcesContainer to defer construction of
resources to the accessor to match the behavior in contexts used in the daemon
How I Tested These Changes
BK