[quick] use correct context type annotations in tests #16507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
3 times, most recently
from
220c25d to
9d0a950
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
e8fa9da to
28e28f8
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
9d0a950 to
9263b7b
Compare
jamiedemaria
force-pushed
the
jamie/provide-asset-context
branch
from
28e28f8 to
12894b6
Compare
jamiedemaria
changed the base branch from
jamie/provide-asset-context
to
jamie/test-asset-context
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
9263b7b to
a017f13
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
896a7d2 to
9d026e9
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
a017f13 to
abb0d04
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
9d026e9 to
beae87d
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
abb0d04 to
959a490
Compare
2 tasks
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
beae87d to
945482e
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
959a490 to
2c77877
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
945482e to
9fbf870
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
2c77877 to
1ac4f61
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
9fbf870 to
5d3c659
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
1ac4f61 to
8b3c446
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
5d3c659 to
c9751d3
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
8b3c446 to
22d84b3
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
c9751d3 to
146248f
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
9d6c13c to
ebb719d
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
72e04ec to
3d8e088
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
ebb719d to
d8903a0
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
3d8e088 to
5fad4f7
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
d8903a0 to
080b503
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
5fad4f7 to
4c8533d
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
080b503 to
c484c0d
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
4c8533d to
f821ec9
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
c484c0d to
fb12ce4
Compare
jamiedemaria
force-pushed
the
jamie/test-asset-context
branch
from
f821ec9 to
ff9ba61
Compare
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
fb12ce4 to
d8d1a5c
Compare
jamiedemaria
changed the base branch from
jamie/test-asset-context
to
master
jamiedemaria
force-pushed
the
jamie/context-pyright
branch
from
d8d1a5c to
0c2765e
Compare
This was referenced Sep 25, 2023
jamiedemaria
changed the title
jamiedemaria
requested review from
alangenfeld,
smackesey,
yuhan,
rexledesma and
schrockn
alangenfeld
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates some context method typing issues that were revealed by making
AssetExecutionContexta subclass ofOpExecutionContextrather than a type alias in #16761How I Tested These Changes