Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expand/collapse section buttons on Runs page #16622

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Sep 19, 2023

Summary & Motivation

Updating these buttons based on the new figma design

Since SplitPanelContianer isn't a controlled component I opted to just track whether the top/bottom is expanded outside of SplitPanelContainer so that we can determine the icon / tooltip to render. I think ideally we make SplitPanelContainer a controlled component but I didn't want to change a bunch of callsites in this PR

How I Tested These Changes

locally
Screenshot 2023-09-19 at 10 23 54 AM
Screenshot 2023-09-19 at 10 23 49 AM
Screenshot 2023-09-19 at 10 23 42 AM
Screenshot 2023-09-19 at 10 23 38 AM

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-fgb2ol9lo-elementl.vercel.app
https://salazarm-runs-expand-tabs.components-storybook.dagster-docs.io

Built with commit eeb5dea.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-987ymc0zn-elementl.vercel.app
https://salazarm-runs-expand-tabs.core-storybook.dagster-docs.io

Built with commit eeb5dea.
This pull request is being automatically deployed with vercel-action

@leahpadgett
Copy link

Looks great! This might be a nit but does the tooltip normally sit above the button/icon vs to the side?

@salazarm
Copy link
Contributor Author

salazarm commented Sep 19, 2023

Looks great! This might be a nit but does the tooltip normally sit above the button/icon vs to the side?

@leahpadgett I can put it on any side we prefer, should I move it to above?

@leahpadgett
Copy link

Looks great! This might be a nit but does the tooltip normally sit above the button/icon vs to the side?

@leahpadgett I can put it on any side we prefer, should I move it to above?

@salazarm I would say yes to be consistent with other tooltips. Thanks Marco!
Screen Shot 2023-09-19 at 11 54 46 AM

@salazarm salazarm force-pushed the salazarm/runs-expand-tabs branch from cdfb192 to 2e09dde Compare September 19, 2023 16:39
@salazarm salazarm merged commit 761cb7f into master Sep 19, 2023
2 checks passed
@salazarm salazarm deleted the salazarm/runs-expand-tabs branch September 19, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants