Make observable source adapter layer compatibility with AMP #16718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2023
Closed
Closed
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
schrockn
force-pushed
the
source-asset-wrapping-5-observable-source-asset-adapter
branch
2 times, most recently
from
1b7fa84 to
ae483e1
Compare
cp explicit use ephem instnace
…izations for observable source asset wrapping more bulletproof codepath defend against non-existent asset_defs better better still f-string
feedabck Extract out observe_fn_to_op_compute_fn to it can be reused in other contexts cp feedback experimental cp cp cp
schrockn
force-pushed
the
source-asset-wrapping-5-observable-source-asset-adapter
branch
from
ae483e1 to
a93f78b
Compare
works cleanup
schrockn
force-pushed
the
source-asset-6-amp-compat
branch
from
d9e0027 to
2e243a2
Compare
schrockn
force-pushed
the
source-asset-wrapping-5-observable-source-asset-adapter
branch
from
dc9eb75 to
fde2c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This adds the ability for AssetGraph to model both external assets definitions and source assets in a unified way in the AMP layer, which relies on
AssetGraphHow I Tested These Changes
BK