Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Playground Example folder and Observable source asset test #17063

Closed
wants to merge 5 commits into from

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Oct 6, 2023

Summary & Motivation

This PR serves two purposes:

  1. To introduce an example I could load into dagster-webserver to test Wrap observable source assets in AssetsDefinition #16620
  2. To add a generalized dumping ground for simple, standalone examples to keep under test. Often you want to have something you can easily load in the UI, but don't want to make any entire new module for. This provides a place where you can dump that sort of thing.

How I Tested These Changes

@schrockn
Copy link
Member Author

schrockn commented Oct 6, 2023

@schrockn schrockn marked this pull request as ready for review October 6, 2023 18:17
@alangenfeld
Copy link
Member

whats the difference between this new examples playground and python_modules/dagster-test/dagster_test/toys/ ?

@schrockn
Copy link
Member Author

schrockn commented Oct 6, 2023

I think nothing. I'll move it.

Base automatically changed from source-asset-wrapping-3-executable-observable-asset to master October 6, 2023 19:20
Copy link
Member

@alangenfeld alangenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill move it

@schrockn schrockn closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants