Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct invocation asset execution context #18549

Merged
merged 17 commits into from
Jan 31, 2024
Merged

Direct invocation asset execution context #18549

merged 17 commits into from
Jan 31, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Dec 6, 2023

Summary & Motivation

This PR introduces a direct invocation AssetExecutionContext. The underlying op_execution_context is a DirectOpExecutionContext. Methods on AssetExecutionContext that have their own implementations, rather than passing through to a method on the op execution context, and access values not available during direct invocation will need to be re-implemented on the DirectAssetExecutionContext (but there are none of those in this PR). The bound/unbound state of this context is maintained on the underlying op context

Introduces a parent class for DirectOpExecutionContext and DirectAssetExecutionContext so we can do type checking in the direct invocation code path

How I Tested These Changes

@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Dec 6, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jamiedemaria jamiedemaria changed the base branch from jamie/two-contexts to jamie/asset-context-deprecation-setup December 6, 2023 23:35
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from e7e7de8 to b8f9c84 Compare December 6, 2023 23:42
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from b8f9c84 to b02eb83 Compare December 7, 2023 19:56
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from b02eb83 to 6e4cf32 Compare December 7, 2023 20:02
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from 6e4cf32 to 4b26c05 Compare December 7, 2023 20:19
@jamiedemaria jamiedemaria force-pushed the jamie/asset-di branch 2 times, most recently from 8fcb99f to a060f2b Compare December 7, 2023 20:29
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from 41e0231 to 2b008bc Compare December 7, 2023 20:53
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from 2b008bc to 4f92faa Compare December 7, 2023 21:26
@jamiedemaria jamiedemaria force-pushed the jamie/asset-di branch 2 times, most recently from 42a4ac0 to f1a239f Compare December 7, 2023 21:35
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from f29383b to 914a6a6 Compare December 8, 2023 19:33
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from 914a6a6 to fc6cef4 Compare December 8, 2023 20:32
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from 6b387ff to 372b752 Compare January 29, 2024 18:16
@jamiedemaria jamiedemaria force-pushed the jamie/asset-context-deprecation-setup branch from 372b752 to d967f43 Compare January 29, 2024 19:44
@jamiedemaria jamiedemaria force-pushed the jamie/asset-di branch 2 times, most recently from f05054c to 03fc95f Compare January 29, 2024 20:03
@jamiedemaria jamiedemaria removed the request for review from erinkcochran87 January 30, 2024 15:28
Copy link
Member

@alangenfeld alangenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks clean to me

Base automatically changed from jamie/asset-context-deprecation-setup to master January 30, 2024 20:18
@jamiedemaria jamiedemaria merged commit f3e4817 into master Jan 31, 2024
1 check passed
@jamiedemaria jamiedemaria deleted the jamie/asset-di branch January 31, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants