-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicate op context methods on asset context #18573
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2023
Merged
jamiedemaria
commented
Dec 7, 2023
python_modules/dagster/dagster/_core/execution/context/compute.py
Outdated
Show resolved
Hide resolved
🙏 |
smackesey
reviewed
Dec 7, 2023
python_modules/dagster/dagster/_core/execution/context/compute.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/execution/context/compute.py
Outdated
Show resolved
Hide resolved
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
December 7, 2023 21:26
61de049
to
76df836
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
2 times, most recently
from
December 8, 2023 19:33
b27c580
to
ce9ce8c
Compare
alangenfeld
approved these changes
Dec 8, 2023
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
December 8, 2023 20:32
54f37c3
to
5efdfba
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
December 8, 2023 20:32
ce9ce8c
to
8984946
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
December 13, 2023 15:08
5efdfba
to
bdbc72a
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
December 13, 2023 15:08
8984946
to
f1d3dcf
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
December 18, 2023 18:27
bdbc72a
to
e945c4f
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
December 18, 2023 18:27
f1d3dcf
to
151dccc
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
December 19, 2023 19:33
e945c4f
to
85ffdb6
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
3 times, most recently
from
December 19, 2023 19:53
8961442
to
946e4d2
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
December 27, 2023 17:55
9ff2c3c
to
f3cca9d
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
January 19, 2024 16:38
4b1f85e
to
8413565
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
January 19, 2024 16:38
6e603f9
to
52e8f24
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
January 19, 2024 19:09
8413565
to
87bf94f
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
January 19, 2024 19:09
52e8f24
to
abaead1
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
January 23, 2024 00:11
87bf94f
to
6fd3e8c
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
January 23, 2024 00:11
abaead1
to
20f6430
Compare
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
January 26, 2024 18:52
6fd3e8c
to
3096474
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
January 26, 2024 18:52
20f6430
to
73d0053
Compare
This was referenced Jan 26, 2024
jamiedemaria
force-pushed
the
jamie/level-1-collapse-DI-contexts
branch
from
January 29, 2024 15:38
3096474
to
92ea8d8
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
2 times, most recently
from
January 29, 2024 16:30
8993489
to
04512cb
Compare
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-3kde0n75t-elementl.vercel.app Direct link to changed pages: |
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
January 29, 2024 17:26
3e9683d
to
784b4c6
Compare
jamiedemaria
force-pushed
the
jamie/asset-duplicate
branch
from
January 29, 2024 18:16
784b4c6
to
4758860
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Duplicates all methods/properties on
OpExecutionContext
toAssetExecutionContext
as pass throughs that just call the underlyingOpExecutionContext
. This is largely to help with bookkeeping as we deprecate op context methods. The idea being that having a copy of all of the methods onAssetExecutionContext
will give us a clearer idea which methods are yet to be deprecated.This also introduces a decorator to copy the doc string from the op context fn to the asset context fn
How I Tested These Changes