Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate op context methods on asset context #18573

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Dec 7, 2023

Summary & Motivation

Duplicates all methods/properties on OpExecutionContext to AssetExecutionContext as pass throughs that just call the underlying OpExecutionContext. This is largely to help with bookkeeping as we deprecate op context methods. The idea being that having a copy of all of the methods on AssetExecutionContext will give us a clearer idea which methods are yet to be deprecated.

This also introduces a decorator to copy the doc string from the op context fn to the asset context fn

How I Tested These Changes

@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Dec 7, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jamiedemaria jamiedemaria marked this pull request as ready for review December 7, 2023 20:16
@smackesey
Copy link
Collaborator

This also introduces a decorator to copy the doc string from the op context fn to the asset context fn

🙏

@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 61de049 to 76df836 Compare December 7, 2023 21:26
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch 2 times, most recently from b27c580 to ce9ce8c Compare December 8, 2023 19:33
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 54f37c3 to 5efdfba Compare December 8, 2023 20:32
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch from ce9ce8c to 8984946 Compare December 8, 2023 20:32
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 5efdfba to bdbc72a Compare December 13, 2023 15:08
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from bdbc72a to e945c4f Compare December 18, 2023 18:27
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from e945c4f to 85ffdb6 Compare December 19, 2023 19:33
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch 3 times, most recently from 8961442 to 946e4d2 Compare December 19, 2023 19:53
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 9ff2c3c to f3cca9d Compare December 27, 2023 17:55
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 4b1f85e to 8413565 Compare January 19, 2024 16:38
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch from 6e603f9 to 52e8f24 Compare January 19, 2024 16:38
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 8413565 to 87bf94f Compare January 19, 2024 19:09
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch from 52e8f24 to abaead1 Compare January 19, 2024 19:09
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 87bf94f to 6fd3e8c Compare January 23, 2024 00:11
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch from abaead1 to 20f6430 Compare January 23, 2024 00:11
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 6fd3e8c to 3096474 Compare January 26, 2024 18:52
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch from 20f6430 to 73d0053 Compare January 26, 2024 18:52
@jamiedemaria jamiedemaria force-pushed the jamie/level-1-collapse-DI-contexts branch from 3096474 to 92ea8d8 Compare January 29, 2024 15:38
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch 2 times, most recently from 8993489 to 04512cb Compare January 29, 2024 16:30
Copy link

github-actions bot commented Jan 29, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-3kde0n75t-elementl.vercel.app
https://jamie-asset-duplicate.dagster.dagster-docs.io

Direct link to changed pages:

@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch from 3e9683d to 784b4c6 Compare January 29, 2024 17:26
Base automatically changed from jamie/level-1-collapse-DI-contexts to master January 29, 2024 18:15
@jamiedemaria jamiedemaria force-pushed the jamie/asset-duplicate branch from 784b4c6 to 4758860 Compare January 29, 2024 18:16
@jamiedemaria jamiedemaria merged commit 102ba14 into master Jan 29, 2024
2 checks passed
@jamiedemaria jamiedemaria deleted the jamie/asset-duplicate branch January 29, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants