Fix colors on daggy u popover #19857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit dcbc9a3. |
prha
approved these changes
Feb 16, 2024
salazarm
added a commit
that referenced
this pull request
Feb 20, 2024
## Summary & Motivation Fix colors on dagster university product tour. Blueprint's dark theme was overriding the link color in the popover and blueprints arrow was on a layer below the popover which made it look a different color due to the box shadow overlaying on it before. ## How I Tested These Changes <img width="327" alt="Screenshot 2024-02-16 at 12 36 16 AM" src="https://github.com/dagster-io/dagster/assets/2286579/c64afdaf-42a5-45ea-bc33-412aba6e8110">
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Fix colors on dagster university product tour. Blueprint's dark theme was overriding the link color in the popover and blueprints arrow was on a layer below the popover which made it look a different color due to the box shadow overlaying on it before. ## How I Tested These Changes <img width="327" alt="Screenshot 2024-02-16 at 12 36 16 AM" src="https://github.com/dagster-io/dagster/assets/2286579/c64afdaf-42a5-45ea-bc33-412aba6e8110">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fix colors on dagster university product tour.
Blueprint's dark theme was overriding the link color in the popover and blueprints arrow was on a layer below the popover which made it look a different color due to the box shadow overlaying on it before.
How I Tested These Changes