syrupy 4

examples/docs_snippets/setup.py

@@ -60,7 +60,7 @@
             "seaborn",
             "scikit-learn",
             "slack_sdk",
-            "syrupy<4",  # 3.7 compatible,
+            "syrupy",
             "dbt-duckdb",
             "xgboost",
             "dagster-webserver[test]",

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

@@ -13,11 +13,14 @@
 import yaml
 from dagster._utils import find_free_port, git_repository_root
 from dagster._utils.merger import merge_dicts
-from dagster_aws_tests.aws_credential_test_utils import get_aws_creds
+from dagster_aws.utils import ensure_dagster_aws_tests_import
 from dagster_k8s.client import DagsterKubernetesClient
 
 from .integration_utils import IS_BUILDKITE, check_output, get_test_namespace, image_pull_policy
 
+ensure_dagster_aws_tests_import()
+from dagster_aws_tests.aws_credential_test_utils import get_aws_creds
+
 TEST_AWS_CONFIGMAP_NAME = "test-aws-env-configmap"
 TEST_CONFIGMAP_NAME = "test-env-configmap"
 TEST_OTHER_CONFIGMAP_NAME = "test-other-env-configmap"

python_modules/dagster-graphql/dagster_graphql/test/utils.py

@@ -1,5 +1,7 @@
 import asyncio
+import sys
 from contextlib import contextmanager
+from pathlib import Path
 from typing import Any, Dict, Iterator, Mapping, Optional, Sequence
 
 import dagster._check as check
@@ -11,6 +13,7 @@
 from dagster._core.workspace.load_target import PythonFileTarget
 from typing_extensions import Protocol, TypeAlias, TypedDict
 
+from dagster_graphql import __file__ as dagster_graphql_init_py
 from dagster_graphql.schema import create_schema
 
 
@@ -222,3 +225,11 @@ def infer_resource_selector(graphql_context: WorkspaceRequestContext, name: str)
     selector = infer_repository_selector(graphql_context)
     selector = {**selector, **{"resourceName": name}}
     return selector
+
+
+def ensure_dagster_graphql_tests_import() -> None:
+    dagster_package_root = (Path(dagster_graphql_init_py) / ".." / "..").resolve()
+    assert (
+        dagster_package_root / "dagster_graphql_tests"
+    ).exists(), "Could not find dagster_graphql_tests where expected"
+    sys.path.append(dagster_package_root.as_posix())

python_modules/dagster-graphql/dagster_graphql_tests/conftest.py

@@ -5,6 +5,7 @@
 from syrupy.extensions.amber import AmberSnapshotExtension
 
 if TYPE_CHECKING:
+    from syrupy.location import PyTestLocation
     from syrupy.types import SnapshotIndex
 
 
@@ -19,8 +20,14 @@ def unset_dagster_home():
 
 
 class SharedSnapshotExtension(AmberSnapshotExtension):
-    def get_snapshot_name(self, *, index: "SnapshotIndex") -> str:
-        snapshot_name = self.test_location.snapshot_name
+    @classmethod
+    def get_snapshot_name(
+        cls,
+        *,
+        index: "SnapshotIndex",
+        test_location: "PyTestLocation",
+    ) -> str:
+        snapshot_name = test_location.snapshot_name
 
         # Exclude any of the GraphQLContextVariant suffixes from the snapshot name
         # so that we don't have to re-generate an identical snapshot for each one

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_all_snapshot_ids.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_all_snapshot_ids[0]
   '''
   {

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_assets.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestAssetAwareEventLog.test_all_asset_keys[0]
   dict({
     'assetsOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_composites.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestComposites.test_composites[0]
   dict({
     'pipelineOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_compute_logs.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestComputeLogs.test_compute_logs_subscription_graphql[0]
   list([
     dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_environment_schema.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestEnvironmentSchema.test_basic_invalid_config_on_run_config_schema[0]
   dict({
     'runConfigSchemaOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_expectations.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestExpectations.test_basic_expectations_within_compute_step_events[0]
   list([
     dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_graph.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestGraphs.test_basic_graphs[0]
   dict({
     'graphOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_input_output_definitions.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_query_inputs_outputs[0]
   dict({
     'repositoryOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_loggers.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_mode_fetch_loggers[0]
   dict({
     'pipelineOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_materializations.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestMaterializations.test_materializations[0]
   list([
     'RunStartingEvent',

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_partition_sets.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestPartitionSets.test_get_partition_set[0]
   dict({
     'partitionSetOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_pipeline_snapshot.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_fetch_snapshot_or_error_by_active_pipeline_name_not_found[0]
   '''
   {

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_reexecution.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestReexecution.test_full_pipeline_reexecution_fs_storage[0]
   dict({
     'launchPipelineExecution': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_resources.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_mode_fetch_resources[0]
   dict({
     'pipelineOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_retry_execution.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestRetryExecution.test_pipeline_reexecution_info_query[0]
   list([
     'sum_sq_op',

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_sensors.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: TestSensors.test_get_sensor[0]
   dict({
     '__typename': 'Sensor',

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_solids.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_query_all_solids[0]
   dict({
     'repositoryOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_top_level_resources.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_fetch_top_level_resource[0]
   dict({
     'topLevelResourceDetailsOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/__snapshots__/test_utilized_env_vars.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_get_used_env_vars[0]
   dict({
     'utilizedEnvVarsOrError': dict({

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_asset_backfill.py

@@ -15,14 +15,16 @@
 )
 from dagster._core.execution.asset_backfill import AssetBackfillData
 from dagster._core.instance import DagsterInstance
-from dagster._core.test_utils import instance_for_test
+from dagster._core.test_utils import ensure_dagster_tests_import, instance_for_test
 from dagster_graphql.client.query import LAUNCH_PARTITION_BACKFILL_MUTATION
 from dagster_graphql.test.utils import (
     GqlResult,
     define_out_of_process_context,
     execute_dagster_graphql,
     main_repo_location_name,
 )
+
+ensure_dagster_tests_import()
 from dagster_tests.definitions_tests.auto_materialize_tests.scenarios.asset_graphs import (
     root_assets_different_partitions_same_downstream,
 )

python_modules/dagster-test/dagster_test_tests/test_toys.py

@@ -16,7 +16,7 @@
 from dagster._core.definitions.unresolved_asset_job_definition import define_asset_job
 from dagster._core.events import DagsterEventType
 from dagster._core.storage.fs_io_manager import fs_io_manager
-from dagster._core.test_utils import instance_for_test
+from dagster._core.test_utils import ensure_dagster_tests_import, instance_for_test
 from dagster._utils import file_relative_path
 from dagster._utils.temp_file import get_temp_dir
 from dagster_test.toys.branches import branch
@@ -39,6 +39,8 @@
 from dagster_test.toys.sensors import get_toys_sensors
 from dagster_test.toys.sleepy import sleepy
 from dagster_test.toys.software_defined_assets import software_defined_assets
+
+ensure_dagster_tests_import()
 from dagster_tests.execution_tests.engine_tests.test_step_delegating_executor import (
     test_step_delegating_executor,
 )

python_modules/dagster/dagster/_core/code_pointer.py

@@ -127,7 +127,6 @@ def load_python_module(
         list(remove_from_path_fn()) if remove_from_path_fn else []
     )  # hook for tests
     remove_paths.insert(0, sys.path[0])  # remove the script path
-
     with alter_sys_path(
         to_add=([working_directory] if working_directory else []), to_remove=remove_paths
     ):

python_modules/dagster/dagster/_core/test_utils.py

@@ -7,6 +7,7 @@
 from collections import defaultdict
 from concurrent.futures import Future, ThreadPoolExecutor
 from contextlib import contextmanager
+from pathlib import Path
 from signal import Signals
 from threading import Event
 from typing import (
@@ -32,6 +33,7 @@
 from dagster import (
     Permissive,
     Shape,
+    __file__ as dagster_init_py,
     _check as check,
     fs_io_manager,
 )
@@ -708,3 +710,11 @@ def raise_exception_on_warnings():
     if sys.version_info >= (3, 12):
         # pendulum sometimes raises DeprecationWarning on python3.12
         warnings.filterwarnings("ignore", category=DeprecationWarning, module="pendulum")
+
+
+def ensure_dagster_tests_import() -> None:
+    dagster_package_root = (Path(dagster_init_py) / ".." / "..").resolve()
+    assert (
+        dagster_package_root / "dagster_tests"
+    ).exists(), "Could not find dagster_tests where expected"
+    sys.path.append(dagster_package_root.as_posix())

python_modules/dagster/dagster_tests/cli_tests/__snapshots__/test_config_scaffolder.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_basic_ops_config
   dict({
     'execution': dict({

python_modules/dagster/dagster_tests/cli_tests/test_api_commands.py

@@ -9,9 +9,15 @@
 from dagster._core.execution.retries import RetryState
 from dagster._core.execution.stats import RunStepKeyStatsSnapshot
 from dagster._core.host_representation import JobHandle
-from dagster._core.test_utils import create_run_for_test, environ, instance_for_test
+from dagster._core.test_utils import (
+    create_run_for_test,
+    ensure_dagster_tests_import,
+    environ,
+    instance_for_test,
+)
 from dagster._serdes import serialize_value
 
+ensure_dagster_tests_import()
 from dagster_tests.api_tests.utils import get_bar_repo_handle, get_foo_job_handle
 
 

python_modules/dagster/dagster_tests/core_tests/snap_tests/__snapshots__/test_active_data.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_external_job_data
   '''
   {

python_modules/dagster/dagster_tests/core_tests/snap_tests/__snapshots__/test_execution_plan.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_create_execution_plan_with_dep
   '''
   {

python_modules/dagster/dagster_tests/core_tests/snap_tests/__snapshots__/test_job_snap.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_basic_dep_fan_out
   '''
   {

python_modules/dagster/dagster_tests/core_tests/snap_tests/__snapshots__/test_legacy_mode_def_snap.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_mode_snap
   '{"__class__": "ModeDefSnap", "description": null, "logger_def_snaps": [{"__class__": "LoggerDefSnap", "config_field_snap": {"__class__": "ConfigFieldSnap", "default_provided": false, "default_value_as_json_str": null, "description": null, "is_required": false, "name": "config", "type_key": "Any"}, "description": "logger_description", "name": "no_config_logger"}, {"__class__": "LoggerDefSnap", "config_field_snap": {"__class__": "ConfigFieldSnap", "default_provided": false, "default_value_as_json_str": null, "description": null, "is_required": true, "name": "config", "type_key": "Shape.6930c1ab2255db7c39e92b59c53bab16a55f80c1"}, "description": null, "name": "some_logger"}], "name": "default", "resource_def_snaps": [{"__class__": "ResourceDefSnap", "config_field_snap": {"__class__": "ConfigFieldSnap", "default_provided": false, "default_value_as_json_str": null, "description": null, "is_required": false, "name": "config", "type_key": "Any"}, "description": "Built-in filesystem IO manager that stores and retrieves values using pickling.", "name": "io_manager"}, {"__class__": "ResourceDefSnap", "config_field_snap": {"__class__": "ConfigFieldSnap", "default_provided": false, "default_value_as_json_str": null, "description": null, "is_required": false, "name": "config", "type_key": "Any"}, "description": "resource_description", "name": "no_config_resource"}, {"__class__": "ResourceDefSnap", "config_field_snap": {"__class__": "ConfigFieldSnap", "default_provided": false, "default_value_as_json_str": null, "description": null, "is_required": true, "name": "config", "type_key": "Shape.4384fce472621a1d43c54ff7e52b02891791103f"}, "description": null, "name": "some_resource"}], "root_config_key": "Shape.02d70527880bf8d440339753c017df76ba0c21b0"}'
 # ---

python_modules/dagster/setup.py

@@ -134,7 +134,7 @@ def get_version() -> str:
             "pytest-xdist==3.3.1",
             "pytest>=7.0.1",
             "responses<=0.23.1",  # https://github.com/getsentry/responses/issues/654
-            "syrupy<4",  # 3.7 compatible,
+            "syrupy>=4.0.0",
             "tox==3.25.0",
             "morefs[asynclocal]; python_version>='3.8'",
         ],

python_modules/libraries/dagster-airflow/dagster_airflow_tests/test_dagster_pipeline_factory/__snapshots__/test_dependency_structure_translation.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_complex_dag
   '''
   {

python_modules/libraries/dagster-aws/dagster_aws/utils/__init__.py

@@ -1,3 +1,5 @@
+import sys
+from pathlib import Path
 from typing import Optional, TypeVar
 
 import dagster._check as check
@@ -7,6 +9,8 @@
 from packaging import version
 from pydantic import Field
 
+from dagster_aws import __file__ as dagster_aws_init_py
+
 
 def construct_boto_client_retry_config(max_attempts):
     check.int_param(max_attempts, "max_attempts")
@@ -36,3 +40,11 @@ class ResourceWithBoto3Configuration(ConfigurableResource):
     profile_name: Optional[str] = Field(
         default=None, description="Specifies a profile to connect that session"
     )
+
+
+def ensure_dagster_aws_tests_import() -> None:
+    dagster_package_root = (Path(dagster_aws_init_py) / ".." / "..").resolve()
+    assert (
+        dagster_package_root / "dagster_aws_tests"
+    ).exists(), "Could not find dagster_aws_tests where expected"
+    sys.path.append(dagster_package_root.as_posix())

python_modules/libraries/dagster-aws/dagster_aws_tests/s3_tests/test_compute_log_manager.py

@@ -13,8 +13,10 @@
 from dagster._core.storage.local_compute_log_manager import IO_TYPE_EXTENSION
 from dagster._core.storage.root import LocalArtifactStorage
 from dagster._core.storage.runs import SqliteRunStorage
-from dagster._core.test_utils import environ, instance_for_test
+from dagster._core.test_utils import ensure_dagster_tests_import, environ, instance_for_test
 from dagster_aws.s3 import S3ComputeLogManager
+
+ensure_dagster_tests_import()
 from dagster_tests.storage_tests.test_captured_log_manager import TestCapturedLogManager
 
 HELLO_WORLD = "Hello World"

python_modules/libraries/dagster-azure/dagster_azure_tests/blob_tests/test_compute_log_manager.py

@@ -12,8 +12,10 @@
 from dagster._core.storage.event_log import SqliteEventLogStorage
 from dagster._core.storage.root import LocalArtifactStorage
 from dagster._core.storage.runs import SqliteRunStorage
-from dagster._core.test_utils import environ
+from dagster._core.test_utils import ensure_dagster_tests_import, environ
 from dagster_azure.blob import AzureBlobComputeLogManager, FakeBlobServiceClient
+
+ensure_dagster_tests_import()
 from dagster_tests.storage_tests.test_captured_log_manager import TestCapturedLogManager
 
 HELLO_WORLD = "Hello World"

python_modules/libraries/dagster-celery-docker/dagster_celery_docker_tests/conftest.py

@@ -1,4 +1,7 @@
 import pytest
+from dagster_aws.utils import ensure_dagster_aws_tests_import
+
+ensure_dagster_aws_tests_import()
 from dagster_aws_tests.aws_credential_test_utils import get_aws_creds
 
 

python_modules/libraries/dagster-docker/dagster_docker_tests/conftest.py

@@ -1,4 +1,7 @@
 import pytest
+from dagster_aws.utils import ensure_dagster_aws_tests_import
+
+ensure_dagster_aws_tests_import()
 from dagster_aws_tests.aws_credential_test_utils import get_aws_creds
 
 

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_compute_log_manager.py

@@ -15,11 +15,13 @@
 from dagster._core.storage.event_log import SqliteEventLogStorage
 from dagster._core.storage.root import LocalArtifactStorage
 from dagster._core.storage.runs import SqliteRunStorage
-from dagster._core.test_utils import environ, instance_for_test
+from dagster._core.test_utils import ensure_dagster_tests_import, environ, instance_for_test
 from dagster_gcp.gcs import GCSComputeLogManager
-from dagster_tests.storage_tests.test_captured_log_manager import TestCapturedLogManager
 from google.cloud import storage
 
+ensure_dagster_tests_import()
+from dagster_tests.storage_tests.test_captured_log_manager import TestCapturedLogManager
+
 HELLO_WORLD = "Hello World"
 SEPARATOR = os.linesep if (os.name == "nt" and sys.version_info < (3,)) else "\n"
 EXPECTED_LOGS = [

python_modules/libraries/dagster-ge/dagster_ge_tests/__snapshots__/test_basic_integ.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_yielded_results_config_pandas[hello_world_pandas_job_v2-./great_expectations]
   '''
 

python_modules/libraries/dagster-ge/dagster_ge_tests/__snapshots__/test_resources.ambr

@@ -1,3 +1,4 @@
+# serializer version: 1
 # name: test_yielded_results_config_pandas[hello_world_pandas_job_v2-./great_expectations]
   '''