Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syrupy 4 #19984

Merged
merged 2 commits into from
Feb 23, 2024
Merged

syrupy 4 #19984

merged 2 commits into from
Feb 23, 2024

Conversation

alangenfeld
Copy link
Member

using uv in tox started to resolve to the new version of syrupy which has api changes and new snapshot formats.

Instead of pinning back I opted to migrate forward.

How I Tested These Changes

bk

This was referenced Feb 22, 2024
@alangenfeld
Copy link
Member Author

alangenfeld commented Feb 22, 2024

Copy link
Collaborator

@smackesey smackesey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -45,7 +45,7 @@ def get_version() -> str:
"deltalake": ["deltalake>=0.15.0"],
"gcp": ["dagster-gcp>=0.19.5"],
"test": [
"pytest>=7.3.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from al/compat-alt to master February 23, 2024 23:08
@alangenfeld alangenfeld merged commit 03c93ac into master Feb 23, 2024
1 check passed
@alangenfeld alangenfeld deleted the al/syrupy4 branch February 23, 2024 23:08
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
using `uv` in `tox` started to resolve to the new version of syrupy
which has api changes and new snapshot formats.

Instead of pinning back I opted to migrate forward. 

## How I Tested These Changes

bk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants