use uv in tox #19871

alangenfeld · 2024-02-16T18:28:25Z

Use uv for env setup in tox to improve performance.

How I Tested These Changes

bk

alangenfeld · 2024-02-16T18:28:38Z

Current dependencies on/for this PR:

use uv in Dockerfiles #19990
use uv in tox #19871 👈
syrupy 4 #19984
editable_mode=compat alternative #19983
[docs] remove run attribution python #19958
master

This stack of pull requests is managed by Graphite.

github-actions · 2024-02-16T18:32:42Z

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-d7l6nfuyi-elementl.vercel.app
https://al-02-16-use-uv-in-tox.dagster.dagster-docs.io

Direct link to changed pages:

alangenfeld · 2024-02-16T20:38:11Z

for uv 0.1.2, currently hitting what I believe some sort of race condition tracked @ astral-sh/uv#1508

python_modules/dagster/dagster/_core/test_utils.py

python_modules/dagster/tox.ini

github-actions · 2024-02-21T23:29:25Z

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-aqmtl56uy-elementl.vercel.app
https://al-02-16-use-uv-in-tox.components-storybook.dagster-docs.io

Built with commit 484dc71.
This pull request is being automatically deployed with vercel-action

alangenfeld · 2024-02-22T18:43:16Z

examples/quickstart_aws/tox.ini

+; version resolution issues prevent using uv
+; install_command = uv pip install {opts} {packages}


https://buildkite.com/dagster/dagster-dagster/builds/76392#018dcde2-43cf-4bd7-9ebb-1f258a983570

alangenfeld · 2024-02-22T18:43:46Z

examples/project_fully_featured/tox.ini

+; version resolution using uv
+; install_command = uv pip install {opts} {packages}


https://buildkite.com/dagster/dagster-dagster/builds/76392#018dcde2-43cc-486c-af55-f9a75e0c6959

alangenfeld · 2024-02-22T18:44:11Z

examples/docs_snippets/tox.ini

+; dagstermill test errors prevent using uv, require compat mode install
+; install_command = uv pip install {opts} {packages}


https://buildkite.com/dagster/dagster-dagster/builds/76392#018dcde2-43c6-4424-977f-a9356964d58c

alangenfeld · 2024-02-22T18:45:39Z

python_modules/dagster-test/tox.ini

+; soemthing goes awry with jupyter when using uv
+; install_command = uv pip install {opts} {packages}


https://buildkite.com/dagster/dagster-dagster/builds/76010#018db388-ed89-40ab-8f40-741975c1dc0c

alangenfeld · 2024-02-22T18:46:16Z

python_modules/libraries/dagster-airflow/tox.ini

+; mix of issues prevent use of uv
+; install_command = uv pip install {opts} {packages}


airflow entries here https://buildkite.com/dagster/dagster-dagster/builds/76392#_

alangenfeld · 2024-02-22T18:47:26Z

python_modules/libraries/dagstermill/tox.ini

+; soemthing goes awry with jupyter when using uv
+; install_command = uv pip install {opts} {packages}


https://buildkite.com/dagster/dagster-dagster/builds/75991#018db360-cb10-4073-af74-643f0918211d

sbquinlan · 2024-02-22T23:04:27Z

lgtm. "Python Sean" (@smackesey) to stamp

smackesey

Let's merge it and try to fix the special cases over the next week or so. Pretty sure the devs will help us work through the issues.

Use uv for env setup in tox to improve performance. ## How I Tested These Changes bk

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch 5 times, most recently from 881bbb2 to 2a10a5d Compare February 16, 2024 19:52

alangenfeld changed the title ~~use uv in tox~~ [WIP] use uv in tox Feb 16, 2024

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch 3 times, most recently from b59a7b8 to 58a02c6 Compare February 16, 2024 20:36

alangenfeld commented Feb 16, 2024

View reviewed changes

python_modules/dagster/dagster/_core/test_utils.py Show resolved Hide resolved

alangenfeld commented Feb 16, 2024

View reviewed changes

python_modules/dagster/tox.ini Show resolved Hide resolved

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch 2 times, most recently from 6b68d39 to 2c1dff5 Compare February 20, 2024 23:30

alangenfeld changed the base branch from master to al/02-21-_docs_remove_run_attribution_python February 21, 2024 22:51

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from 2c1dff5 to 0423a1e Compare February 21, 2024 22:52

alangenfeld mentioned this pull request Feb 21, 2024

[docs] remove run attribution python #19958

Merged

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from 0423a1e to 9bb8de2 Compare February 21, 2024 23:25

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch 3 times, most recently from f25d007 to 00dc181 Compare February 21, 2024 23:52

alangenfeld force-pushed the al/02-21-_docs_remove_run_attribution_python branch from 2e833e5 to 0e127b9 Compare February 22, 2024 18:25

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from 00dc181 to cf2adcd Compare February 22, 2024 18:25

alangenfeld changed the base branch from al/02-21-_docs_remove_run_attribution_python to al/syrupy4 February 22, 2024 18:39

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from cf2adcd to e01d4bf Compare February 22, 2024 18:39

This was referenced Feb 22, 2024

editable_mode=compat alternative #19983

Merged

syrupy 4 #19984

Merged

alangenfeld changed the title ~~[WIP] use uv in tox~~ use uv in tox Feb 22, 2024

alangenfeld marked this pull request as ready for review February 22, 2024 18:40

alangenfeld requested a review from erinkcochran87 as a code owner February 22, 2024 18:40

alangenfeld requested a review from smackesey February 22, 2024 18:40

alangenfeld commented Feb 22, 2024

View reviewed changes

alangenfeld force-pushed the al/syrupy4 branch from 05362f5 to 5041766 Compare February 22, 2024 18:55

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from e01d4bf to ff12bf1 Compare February 22, 2024 18:55

alangenfeld force-pushed the al/syrupy4 branch from 5041766 to ad10be4 Compare February 22, 2024 20:53

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from ff12bf1 to ed5a990 Compare February 22, 2024 20:53

alangenfeld mentioned this pull request Feb 22, 2024

use uv in Dockerfiles #19990

Merged

erinkcochran87 removed their request for review February 22, 2024 21:19

alangenfeld requested review from sbquinlan and yuhan February 22, 2024 23:00

sbquinlan removed their request for review February 22, 2024 23:04

alangenfeld force-pushed the al/syrupy4 branch from ad10be4 to c73269f Compare February 23, 2024 15:27

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from ed5a990 to 8215804 Compare February 23, 2024 15:27

smackesey approved these changes Feb 23, 2024

View reviewed changes

alangenfeld added 4 commits February 23, 2024 14:23

compat-settings alternative

49bec11

syrupy 4

f3531cd

polars pytest pin

5f3f9bf

use uv in tox

484dc71

alangenfeld force-pushed the al/syrupy4 branch from c73269f to f3531cd Compare February 23, 2024 20:24

alangenfeld force-pushed the al/02-16-use_uv_in_tox branch from 8215804 to 484dc71 Compare February 23, 2024 20:24

Base automatically changed from al/syrupy4 to master February 23, 2024 23:08

alangenfeld merged commit 059e3cd into master Feb 23, 2024
3 checks passed

alangenfeld deleted the al/02-16-use_uv_in_tox branch February 23, 2024 23:08

PedramNavid pushed a commit that referenced this pull request Mar 28, 2024

use uv in tox (#19871)

c01711d

Use uv for env setup in tox to improve performance. ## How I Tested These Changes bk

rexledesma mentioned this pull request Aug 7, 2024

Upgrade to tox 4 #23449

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use uv in tox #19871

use uv in tox #19871

alangenfeld commented Feb 16, 2024 •

edited

Loading

alangenfeld commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

alangenfeld commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading

alangenfeld Feb 22, 2024

alangenfeld Feb 22, 2024

alangenfeld Feb 22, 2024

alangenfeld Feb 22, 2024

alangenfeld Feb 22, 2024

alangenfeld Feb 22, 2024

sbquinlan commented Feb 22, 2024

smackesey left a comment

		; version resolution issues prevent using uv
		; install_command = uv pip install {opts} {packages}

		; version resolution using uv
		; install_command = uv pip install {opts} {packages}

		; dagstermill test errors prevent using uv, require compat mode install
		; install_command = uv pip install {opts} {packages}

		; soemthing goes awry with jupyter when using uv
		; install_command = uv pip install {opts} {packages}

		; mix of issues prevent use of uv
		; install_command = uv pip install {opts} {packages}

use uv in tox #19871

use uv in tox #19871

Conversation

alangenfeld commented Feb 16, 2024 • edited Loading

How I Tested These Changes

alangenfeld commented Feb 16, 2024 • edited Loading

github-actions bot commented Feb 16, 2024 • edited Loading

alangenfeld commented Feb 16, 2024 • edited Loading

github-actions bot commented Feb 21, 2024 • edited Loading

alangenfeld Feb 22, 2024

Choose a reason for hiding this comment

alangenfeld Feb 22, 2024

Choose a reason for hiding this comment

alangenfeld Feb 22, 2024

Choose a reason for hiding this comment

alangenfeld Feb 22, 2024

Choose a reason for hiding this comment

alangenfeld Feb 22, 2024

Choose a reason for hiding this comment

alangenfeld Feb 22, 2024

Choose a reason for hiding this comment

sbquinlan commented Feb 22, 2024

smackesey left a comment

Choose a reason for hiding this comment

alangenfeld commented Feb 16, 2024 •

edited

Loading

alangenfeld commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 16, 2024 •

edited

Loading

alangenfeld commented Feb 16, 2024 •

edited

Loading

github-actions bot commented Feb 21, 2024 •

edited

Loading