Upgrade to tox 4

[PedramNavid]

Summary & Motivation

Tox 3 was last updated in 2022. It's time to move to tox 4. The only breaking change is passenv variables need to be on a new line

How I Tested These Changes

bk

[PedramNavid]

• Upgrade to tox 4 #23449 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @PedramNavid and the rest of your teammates on Graphite

[github-actions]

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-65h8u3o0v-elementl.vercel.app
https://pdrm-tox-4.components-storybook.dagster-docs.io

Built with commit 7275325.
This pull request is being automatically deployed with vercel-action

[rexledesma]

We should make this run against the full suite + all python versions just to double check that everything is fine.

You can add a magic string in your commit message to do that: https://www.notion.so/dagster/Buildkite-01a5666c2527462db2c3abe0d98cde45?pvs=4#55a86580485948c2877c55e62fe7fa39

[github-actions]

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-gu13jyx8o-elementl.vercel.app
https://pdrm-tox-4.dagster.dagster-docs.io

Direct link to changed pages:

[PedramNavid]

We should make this run against the full suite + all python versions just to double check that everything is fine.

You can add a magic string in your commit message to do that: https://www.notion.so/dagster/Buildkite-01a5666c2527462db2c3abe0d98cde45?pvs=4#55a86580485948c2877c55e62fe7fa39

good call, just ran

[rexledesma]

Sweet, thanks! Is there a corresponding PR for internal as well? Going to request changes just to make sure that's present.

• Let's ensure tox>=4 just to be safe
• Let's update tox.ini.tmpl in the python package scaffold as well

[PedramNavid]

Sweet, thanks! Is there a corresponding PR for internal as well? Going to request changes just to make sure that's present.

• Let's ensure tox>=4 just to be safe
• Let's update tox.ini.tmpl in the python package scaffold as well

Added! TIL about the python package scaffold. This whole time I was copy pasting files from other packages that looked decent 😭

[rexledesma]

yahoo

[schrockn]

What are the concrete benefits we get out of the upgrade?

[PedramNavid]

What are the concrete benefits we get out of the upgrade?

There’s some performance improvements to start times and better handling of dependency changes, eg when adding a new package while developing.

But really, I sometimes end up with tox 4 in my environment somehow and it would never run and I’d end up reinstalling 3.2.5 which annoyed me, which was the real motivation for this

[schrockn]

Makes sense! Obviously in support. Just wondering what concrete goodies we get.

[PedramNavid]

Makes sense! Obviously in support. Just wondering what concrete goodies we get.

Ohh there's also this:
https://github.com/tox-dev/tox-uv
which requires tox>=4.16

[PedramNavid]

Merge activity

• Aug 7, 12:16 PM EDT: @PedramNavid started a stack merge that includes this pull request via Graphite.
• Aug 7, 12:17 PM EDT: @PedramNavid merged this pull request with Graphite.

[rexledesma]

FYI we already use uv in tox: #19871