Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tox 4 #23449

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Upgrade to tox 4 #23449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68f94fa
[TEST_PYTHON_VERSIONS=test-all] upgrade to tox 4
PedramNavid Aug 6, 2024
ae66232
Merge branch 'master' into pdrm/tox-4
PedramNavid Aug 6, 2024
7275325
ensure tox>=4 and add to scaffold
PedramNavid Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/sphinx/_ext/dagster-sphinx/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_PULL_REQUEST COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_PULL_REQUEST
COVERALLS_REPO_TOKEN
BUILDKITE*
allowlist_externals =
/bin/bash
commands =
Expand Down
10 changes: 5 additions & 5 deletions docs/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ skipsdist = True

[testenv]
download = True
passenv = CI_*
COVERALLS_REPO_TOKEN
AWS_SECRET_ACCESS_KEY
AWS_ACCESS_KEY_ID
passenv =
CI_*
COVERALLS_REPO_TOKEN
AWS_SECRET_ACCESS_KEY
AWS_ACCESS_KEY_ID
BUILDKITE*

allowlist_externals =
make
uv
Expand Down
5 changes: 4 additions & 1 deletion examples/assets_dbt_python/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
; note: "source" does not work at this time due to dagster-cloud source access
deps =
Expand Down
5 changes: 4 additions & 1 deletion examples/assets_dynamic_partitions/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/assets_modern_data_stack/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
; note: "source" does not work at this time due to dagster-cloud source access
deps =
Expand Down
5 changes: 4 additions & 1 deletion examples/assets_pandas_pyspark/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/assets_pandas_type_metadata/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/assets_smoke_test/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
6 changes: 5 additions & 1 deletion examples/deploy_docker/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ skipsdist = True

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE* DEPLOY_DOCKER_WEBSERVER_HOST
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
DEPLOY_DOCKER_WEBSERVER_HOST
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
6 changes: 5 additions & 1 deletion examples/deploy_ecs/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ skipsdist = True

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE* DEPLOY_DOCKER_WEBSERVER_HOST
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
DEPLOY_DOCKER_WEBSERVER_HOST
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/deploy_k8s/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = True

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/development_to_production/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = True

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
6 changes: 5 additions & 1 deletion examples/docs_snippets/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN POSTGRES_TEST_DB_HOST BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
POSTGRES_TEST_DB_HOST
BUILDKITE*
; dagstermill test errors prevent using uv, require compat mode install
; install_command = uv pip install {opts} {packages}
install_command = python -m pip install {opts} {packages} --config-settings editable_mode=compat
Expand Down
5 changes: 4 additions & 1 deletion examples/experimental/assets_yaml_dsl/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/experimental/dagster-airlift/examples/peering-with-dbt/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../../../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/experimental/dagster-airlift/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/experimental/dagster-blueprints/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/feature_graph_backed_assets/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
8 changes: 7 additions & 1 deletion examples/project_fully_featured/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE* SNOWFLAKE_ACCOUNT SNOWFLAKE_USER SNOWFLAKE_PASSWORD
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
SNOWFLAKE_ACCOUNT
SNOWFLAKE_USER
SNOWFLAKE_PASSWORD
; version resolution using uv
; install_command = uv pip install {opts} {packages}
deps =
Expand Down
5 changes: 4 additions & 1 deletion examples/quickstart_aws/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
; version resolution issues prevent using uv
; install_command = uv pip install {opts} {packages}

Expand Down
5 changes: 4 additions & 1 deletion examples/quickstart_etl/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
; note: "source" does not work at this time due to dagster-cloud source access
deps =
Expand Down
5 changes: 4 additions & 1 deletion examples/quickstart_gcp/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
; note: "source" does not work at this time due to dagster-cloud source access
deps =
Expand Down
5 changes: 4 additions & 1 deletion examples/quickstart_snowflake/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
; note: "source" does not work at this time due to dagster-cloud source access
deps =
Expand Down
5 changes: 4 additions & 1 deletion examples/with_airflow/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
; uv has trouble with resolve
; https://buildkite.com/dagster/dagster-dagster/builds/76502#018dd221-e24c-40c2-a459-693bdb456f8f
; install_command = uv pip install {opts} {packages}
Expand Down
5 changes: 4 additions & 1 deletion examples/with_great_expectations/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/with_pyspark/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/with_pyspark_emr/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion examples/with_wandb/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = true
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE
install_command = uv pip install {opts} {packages}
deps =
-e ../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion helm/dagster/schema/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../../python_modules/dagster[test]
Expand Down
5 changes: 4 additions & 1 deletion integration_tests/python_modules/dagster-k8s-test-infra/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ skipsdist = true

[testenv]
download = True
passenv = CI_* COVERALLS_REPO_TOKEN BUILDKITE*
passenv =
CI_*
COVERALLS_REPO_TOKEN
BUILDKITE*
install_command = uv pip install {opts} {packages}
deps =
-e ../../../python_modules/dagster[test]
Expand Down
13 changes: 12 additions & 1 deletion integration_tests/test_suites/auto_materialize_perf_tests/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,18 @@ skipsdist = True

[testenv]
download = True
passenv = HOME AIRFLOW_HOME AWS_* BUILDKITE* CI_* COVERALLS_REPO_TOKEN DAGSTER_* DOCKER_* GOOGLE_* KUBECONFIG POSTGRES_TEST_DB_HOST
passenv =
HOME
AIRFLOW_HOME
AWS_*
BUILDKITE*
CI_*
COVERALLS_REPO_TOKEN
DAGSTER_*
DOCKER_*
GOOGLE_*
KUBECONFIG
POSTGRES_TEST_DB_HOST
install_command = uv pip install {opts} {packages}
deps =
-e ../../../python_modules/dagster[test]
Expand Down
Loading