Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[embedded-elt] Deprecate Sling factory method and SlingSource and SlingTarget Resources #19998

Merged
merged 16 commits into from
Feb 28, 2024

Conversation

PedramNavid
Copy link
Contributor

@PedramNavid PedramNavid commented Feb 23, 2024

Summary & Motivation

Deprecate the old Sling asset builders in favor of the new asset decorator.

Note: I could not get the deprecations to show up in local development. Putting this up for review in case it's obvious what I'm doing wrong.

Copy link
Contributor Author

PedramNavid commented Feb 23, 2024

@PedramNavid PedramNavid marked this pull request as ready for review February 23, 2024 03:58
Base automatically changed from pdrm/sling-decorator to master February 23, 2024 20:58
@PedramNavid PedramNavid changed the base branch from master to pdrm/sling-example February 23, 2024 22:32
Base automatically changed from pdrm/sling-example to master February 23, 2024 23:19
@PedramNavid PedramNavid force-pushed the pdrm/sling-deprecate branch 2 times, most recently from 79818bc to 5cd3761 Compare February 25, 2024 05:02
Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…onfig paths; added CSV to SQLite replication test and configs.
- Yield sanitized stdout with timings from `replicate` method in SlingResource.
- Capture raw logs in `_stdout` list for later streaming.
- Include elapsed time metadata in `MaterializeResult` when yielding sync results.
- Add Docker-related files for testing Postgres to DuckDB replication using Sling.
@PedramNavid PedramNavid merged commit 966482c into master Feb 28, 2024
1 check passed
@PedramNavid PedramNavid deleted the pdrm/sling-deprecate branch February 28, 2024 03:46
shalabhc pushed a commit that referenced this pull request Feb 28, 2024
…ngTarget Resources (#19998)

## Summary & Motivation

Deprecate the old Sling asset builders in favor of the new asset decorator.
cmpadden pushed a commit that referenced this pull request Feb 28, 2024
…ngTarget Resources (#19998)

## Summary & Motivation

Deprecate the old Sling asset builders in favor of the new asset decorator.
PedramNavid added a commit that referenced this pull request Mar 28, 2024
…ngTarget Resources (#19998)

## Summary & Motivation

Deprecate the old Sling asset builders in favor of the new asset decorator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants