-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[embedded-elt] Deprecate Sling factory method and SlingSource and SlingTarget Resources #19998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
February 23, 2024 03:57
860f58c
to
bf0c4dd
Compare
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
February 23, 2024 03:57
3280a62
to
ecb39fe
Compare
PedramNavid
force-pushed
the
pdrm/sling-decorator
branch
from
February 23, 2024 05:48
bf0c4dd
to
c5313b7
Compare
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
February 23, 2024 05:48
ecb39fe
to
82f9393
Compare
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
February 23, 2024 22:32
bac7f6a
to
e5110d0
Compare
PedramNavid
force-pushed
the
pdrm/sling-example
branch
from
February 23, 2024 22:35
0f97c58
to
81364d1
Compare
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
2 times, most recently
from
February 25, 2024 05:02
79818bc
to
5cd3761
Compare
This was referenced Feb 25, 2024
cmpadden
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
February 26, 2024 23:50
5cd3761
to
4f108d8
Compare
…onfig paths; added CSV to SQLite replication test and configs.
- Yield sanitized stdout with timings from `replicate` method in SlingResource. - Capture raw logs in `_stdout` list for later streaming. - Include elapsed time metadata in `MaterializeResult` when yielding sync results. - Add Docker-related files for testing Postgres to DuckDB replication using Sling.
…s for disabled asset configs.
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
February 28, 2024 03:24
4f108d8
to
a2a19d4
Compare
SlingTarget Resources
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
February 28, 2024 03:26
a2a19d4
to
071fb51
Compare
shalabhc
pushed a commit
that referenced
this pull request
Feb 28, 2024
…ngTarget Resources (#19998) ## Summary & Motivation Deprecate the old Sling asset builders in favor of the new asset decorator.
cmpadden
pushed a commit
that referenced
this pull request
Feb 28, 2024
…ngTarget Resources (#19998) ## Summary & Motivation Deprecate the old Sling asset builders in favor of the new asset decorator.
PedramNavid
added a commit
that referenced
this pull request
Mar 28, 2024
…ngTarget Resources (#19998) ## Summary & Motivation Deprecate the old Sling asset builders in favor of the new asset decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Deprecate the old Sling asset builders in favor of the new asset decorator.
Note: I could not get the deprecations to show up in local development. Putting this up for review in case it's obvious what I'm doing wrong.