-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix the code block transformer so it doesn't include line comments/pragmas #20029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2024
Merged
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
PedramNavid
force-pushed
the
pdrm/docs-fix-code-block-transformer
branch
from
February 25, 2024 23:32
0fdb0f9
to
bea4af6
Compare
PedramNavid
changed the base branch from
pdrm/sling-docs-v2
to
pdrm/docs-quiet-sphinx
February 25, 2024 23:32
cmpadden
approved these changes
Feb 26, 2024
PedramNavid
force-pushed
the
pdrm/docs-fix-code-block-transformer
branch
from
February 26, 2024 22:24
bea4af6
to
d4bc29e
Compare
PedramNavid
force-pushed
the
pdrm/docs-fix-code-block-transformer
branch
from
February 26, 2024 23:06
81b7976
to
4498e93
Compare
cmpadden
pushed a commit
that referenced
this pull request
Feb 28, 2024
…ents/pragmas (#20029) ## Summary & Motivation Fixes the code block transformer so it doesn't include line comments/pragmas. ## How I Tested These Changes I looked at the diffs
PedramNavid
added a commit
that referenced
this pull request
Mar 28, 2024
…ents/pragmas (#20029) ## Summary & Motivation Fixes the code block transformer so it doesn't include line comments/pragmas. ## How I Tested These Changes I looked at the diffs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes the code block transformer so it doesn't include line comments/pragmas.
Prettier auto-formatted these changes, not sure if they should be included or if I have a bad prettier config.
How I Tested These Changes
i looked at the diffs