Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix the code block transformer so it doesn't include line comments/pragmas #20029

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

PedramNavid
Copy link
Contributor

@PedramNavid PedramNavid commented Feb 25, 2024

Summary & Motivation

Fixes the code block transformer so it doesn't include line comments/pragmas.

Prettier auto-formatted these changes, not sure if they should be included or if I have a bad prettier config.

How I Tested These Changes

i looked at the diffs

Copy link
Contributor Author

PedramNavid commented Feb 25, 2024

@PedramNavid PedramNavid force-pushed the pdrm/docs-fix-code-block-transformer branch from 0fdb0f9 to bea4af6 Compare February 25, 2024 23:32
@PedramNavid PedramNavid changed the base branch from pdrm/sling-docs-v2 to pdrm/docs-quiet-sphinx February 25, 2024 23:32
Base automatically changed from pdrm/docs-quiet-sphinx to master February 26, 2024 22:21
@PedramNavid PedramNavid force-pushed the pdrm/docs-fix-code-block-transformer branch from bea4af6 to d4bc29e Compare February 26, 2024 22:24
@PedramNavid PedramNavid force-pushed the pdrm/docs-fix-code-block-transformer branch from 81b7976 to 4498e93 Compare February 26, 2024 23:06
@PedramNavid PedramNavid merged commit 0f54d8a into master Feb 26, 2024
2 checks passed
@PedramNavid PedramNavid deleted the pdrm/docs-fix-code-block-transformer branch February 26, 2024 23:17
cmpadden pushed a commit that referenced this pull request Feb 28, 2024
…ents/pragmas (#20029)

## Summary & Motivation

Fixes the code block transformer so it doesn't include line comments/pragmas. 

## How I Tested These Changes

I looked at the diffs
@erinkcochran87 erinkcochran87 added the area: docs Related to documentation in general label Mar 22, 2024
PedramNavid added a commit that referenced this pull request Mar 28, 2024
…ents/pragmas (#20029)

## Summary & Motivation

Fixes the code block transformer so it doesn't include line comments/pragmas. 

## How I Tested These Changes

I looked at the diffs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants