Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Dash icon #20341

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[ui] Dash icon #20341

merged 1 commit into from
Mar 8, 2024

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Mar 7, 2024

Summary & Motivation

Replace subtract icon with dash icon, as defined in Figma.

How I Tested These Changes

Storybook

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Mar 7, 2024

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-a0sdlc2l0-elementl.vercel.app
https://dish-dash-icon.components-storybook.dagster-docs.io

Built with commit 74147b0.
This pull request is being automatically deployed with vercel-action

@hellendag hellendag requested a review from leahpadgett March 7, 2024 20:55
@hellendag hellendag marked this pull request as ready for review March 7, 2024 20:55
Copy link

github-actions bot commented Mar 7, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-bqhfalh37-elementl.vercel.app
https://dish-dash-icon.core-storybook.dagster-docs.io

Built with commit 74147b0.
This pull request is being automatically deployed with vercel-action

@hellendag hellendag requested review from bengotow and salazarm March 7, 2024 21:26
@hellendag hellendag merged commit 3e6ef06 into master Mar 8, 2024
2 of 3 checks passed
@hellendag hellendag deleted the dish/dash-icon branch March 8, 2024 15:40
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
## Summary & Motivation

Replace `subtract` icon with `dash` icon, as defined in Figma.

## How I Tested These Changes

Storybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants