[ui-components] Delayed, SpinnerWithText #20448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
hellendag
commented
Mar 13, 2024
| return () => clearTimeout(timer); | ||
| }, [delayMsec]); | ||
|
|
||
| return value; | ||
| return ready; |
There was a problem hiding this comment.
Renamed this var because I found that it's not clear what "value" is supposed to mean.
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 8ade008. |
Merge activity
|
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Extract a couple of our common loading-state UI patterns into ui-components. - `Delayed`, which uses `useDelayedState` to delay showing content. This is useful for delaying when we show a loading state, so that we don't flash it quickly when loading is fairly fast. - `SpinnerWithText`, to show a body-text spinner with a line of text. ## How I Tested These Changes Storybook, Jest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Extract a couple of our common loading-state UI patterns into ui-components.
Delayed, which usesuseDelayedStateto delay showing content. This is useful for delaying when we show a loading state, so that we don't flash it quickly when loading is fairly fast.SpinnerWithText, to show a body-text spinner with a line of text.How I Tested These Changes
Storybook, Jest.