[ui] Allow disabling Settings left pane items #20449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 31c8a91. |
salazarm
approved these changes
Mar 14, 2024
Merge activity
|
hellendag
force-pushed
the
dish/settings-disabled-item
branch
from
31199b8 to
31c8a91
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Add props to allow disabling side nav items in Settings. This is similar to the behavior of our tab components. Also fix the font-size on button items, it's currently a bit too small. ## How I Tested These Changes In Cloud, set permissions checks to fail for a couple of Settings items. Verify that they appear as disabled, with tooltips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add props to allow disabling side nav items in Settings. This is similar to the behavior of our tab components.
Also fix the font-size on button items, it's currently a bit too small.
How I Tested These Changes
In Cloud, set permissions checks to fail for a couple of Settings items. Verify that they appear as disabled, with tooltips.