[Popover] default enforceFocus to false to prevent issue with nested popovers
#21012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 15ca9dd. |
hellendag
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes: https://linear.app/dagster-labs/issue/FE-252/daggy-u-dialog-blocks-input-in-textboxes-during-serverless-nux
Nested blueprint popovers are buggy, blueprint recommends setting
enforceFocus=falseon the outermost popover in this case. We're going to set enforceFocus=false as the default instead of on a case by case basis to prevent further instances of the bug and because there hasn't been any case where we intentionally wanted to enforce focus.How I Tested These Changes
With storybook