Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DbtProject] RFC: Update API post dogfooding #22534

Merged

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jun 13, 2024

Summary & Motivation

This PR updates the API for 2 of the DbtProject attributes:

  • target_path becomes output_path
    • Target path is the accurate name for the output path in dbt, but this was motivated by the following
      • We plan on adding more *Project classes, like SdfProject, and would like to standardize the naming across classes
      • DbtProject had both the attributes target and target_path, which means totally different things in this context which is slightly confusing for someone that is not familiar with all dbt concepts.
      • Edit: we will keep target_path as is to keep the name close to the dbt concept.
  • manifest_preparer becomes preparer
    • This is mostly motivated by [DbtProject] Implement prepare_if_dev #22513, but also
      • we'd like to standardize the naming where possible, and preparer would make more sense with other classes like SdfProject
      • The DagsterDbtManifestPreparer doesn't prepare only the manifest, but also the dependencies with dbt deps
        • DagstetDbtManifestPreparer and DbtManifestPreparer would stay experimental are to be renamed in another PR.

Before being merged, these changes should be thoroughly discussed.

How I Tested These Changes

BK with already existing tests

Copy link
Contributor Author

maximearmstrong commented Jun 13, 2024

Copy link

github-actions bot commented Jun 13, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-pwh04q0j4-elementl.vercel.app
https://maxime-ds-273-update-dbtproject-post-dogfooding-session.dagster.dagster-docs.io

Direct link to changed pages:

@maximearmstrong maximearmstrong self-assigned this Jun 13, 2024
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from c63953d to 06572b5 Compare June 13, 2024 18:21
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch 2 times, most recently from b0072a7 to 1c7b176 Compare June 13, 2024 19:30
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from 4e0d1f4 to ca3b7b9 Compare June 13, 2024 19:45
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from 1c7b176 to fdb9e85 Compare June 13, 2024 19:45
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from ca3b7b9 to f796b77 Compare June 13, 2024 21:41
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from fdb9e85 to 5335422 Compare June 13, 2024 21:41
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from f796b77 to 7529b1c Compare June 14, 2024 19:52
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch 3 times, most recently from c216155 to 2b27b8a Compare June 14, 2024 20:24
@maximearmstrong maximearmstrong changed the title [DbtProject] Update API post dogfooding [DbtProject] RFC: Update API post dogfooding Jun 14, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review June 14, 2024 20:38
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jun 14, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 June 14, 2024 20:38
@maximearmstrong maximearmstrong requested review from sryza, rexledesma and yuhan and removed request for erinkcochran87 June 14, 2024 20:38
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from e4e0e09 to 25a9212 Compare June 17, 2024 19:50
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from 2b27b8a to ce5fc4a Compare June 17, 2024 19:50
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from 25a9212 to 3351dff Compare June 17, 2024 20:38
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from ce5fc4a to b523a75 Compare June 17, 2024 20:38
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from 5955604 to d125ada Compare June 21, 2024 17:08
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from 50e40ff to 2725bcd Compare June 21, 2024 17:08
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from d125ada to 089ce3e Compare June 21, 2024 17:12
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from 2725bcd to a7cec0b Compare June 21, 2024 17:12
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from 089ce3e to a13fb19 Compare June 21, 2024 17:16
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from a7cec0b to 5a340f2 Compare June 21, 2024 17:17
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from a13fb19 to 247ff7d Compare June 21, 2024 19:00
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from 5a340f2 to bd4a64a Compare June 21, 2024 19:00
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from 247ff7d to 4a592bf Compare June 21, 2024 19:52
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from bd4a64a to 6f07414 Compare June 21, 2024 19:52
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from 4a592bf to ff4bdf0 Compare June 24, 2024 19:09
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from 6f07414 to cc91828 Compare June 24, 2024 19:09
@maximearmstrong maximearmstrong force-pushed the maxime/ds-317/remove-side-effect-from-dbtproject-constructor branch from ff4bdf0 to d9dcceb Compare June 26, 2024 17:16
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from cc91828 to 982a802 Compare June 26, 2024 17:16
Base automatically changed from maxime/ds-317/remove-side-effect-from-dbtproject-constructor to master June 27, 2024 13:41
@maximearmstrong maximearmstrong force-pushed the maxime/ds-273/update-dbtproject-post-dogfooding-session branch from 982a802 to f4ee996 Compare June 27, 2024 13:43
@maximearmstrong maximearmstrong dismissed sryza’s stale review June 27, 2024 14:21

Approved by Rex

@maximearmstrong maximearmstrong merged commit f35abde into master Jun 27, 2024
2 checks passed
@maximearmstrong maximearmstrong deleted the maxime/ds-273/update-dbtproject-post-dogfooding-session branch June 27, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants