-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DbtProject] RFC: Update API post dogfooding #22534
Merged
maximearmstrong
merged 9 commits into
master
from
maxime/ds-273/update-dbtproject-post-dogfooding-session
Jun 27, 2024
Merged
[DbtProject] RFC: Update API post dogfooding #22534
maximearmstrong
merged 9 commits into
master
from
maxime/ds-273/update-dbtproject-post-dogfooding-session
Jun 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maximearmstrong and the rest of your teammates on Graphite |
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-pwh04q0j4-elementl.vercel.app Direct link to changed pages: |
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 13, 2024 18:21
c63953d
to
06572b5
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
2 times, most recently
from
June 13, 2024 19:30
b0072a7
to
1c7b176
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 13, 2024 19:45
4e0d1f4
to
ca3b7b9
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 13, 2024 19:45
1c7b176
to
fdb9e85
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 13, 2024 21:41
ca3b7b9
to
f796b77
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 13, 2024 21:41
fdb9e85
to
5335422
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 14, 2024 19:52
f796b77
to
7529b1c
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
3 times, most recently
from
June 14, 2024 20:24
c216155
to
2b27b8a
Compare
maximearmstrong
changed the title
[DbtProject] Update API post dogfooding
[DbtProject] RFC: Update API post dogfooding
Jun 14, 2024
maximearmstrong
requested review from
sryza,
rexledesma and
yuhan
and removed request for
erinkcochran87
June 14, 2024 20:38
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 17, 2024 19:50
e4e0e09
to
25a9212
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 17, 2024 19:50
2b27b8a
to
ce5fc4a
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 17, 2024 20:38
25a9212
to
3351dff
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 17, 2024 20:38
ce5fc4a
to
b523a75
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 21, 2024 17:08
5955604
to
d125ada
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 21, 2024 17:08
50e40ff
to
2725bcd
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 21, 2024 17:12
d125ada
to
089ce3e
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 21, 2024 17:12
2725bcd
to
a7cec0b
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 21, 2024 17:16
089ce3e
to
a13fb19
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 21, 2024 17:17
a7cec0b
to
5a340f2
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 21, 2024 19:00
a13fb19
to
247ff7d
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 21, 2024 19:00
5a340f2
to
bd4a64a
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 21, 2024 19:52
247ff7d
to
4a592bf
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 21, 2024 19:52
bd4a64a
to
6f07414
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 24, 2024 19:09
4a592bf
to
ff4bdf0
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 24, 2024 19:09
6f07414
to
cc91828
Compare
maximearmstrong
force-pushed
the
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
branch
from
June 26, 2024 17:16
ff4bdf0
to
d9dcceb
Compare
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 26, 2024 17:16
cc91828
to
982a802
Compare
Base automatically changed from
maxime/ds-317/remove-side-effect-from-dbtproject-constructor
to
master
June 27, 2024 13:41
maximearmstrong
force-pushed
the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
from
June 27, 2024 13:43
982a802
to
f4ee996
Compare
maximearmstrong
deleted the
maxime/ds-273/update-dbtproject-post-dogfooding-session
branch
June 27, 2024 14:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR updates the API for 2 of the
DbtProject
attributes:target_path
becomesoutput_path
Target path is the accurate name for the output path in dbt, but this was motivated by the followingWe plan on adding more *Project classes, likeSdfProject
, and would like to standardize the naming across classesDbtProject had both the attributestarget
andtarget_path
, which means totally different things in this context which is slightly confusing for someone that is not familiar with all dbt concepts.target_path
as is to keep the name close to the dbt concept.manifest_preparer
becomespreparer
prepare_if_dev
#22513, but alsopreparer
would make more sense with other classes likeSdfProject
DagsterDbtManifestPreparer
doesn't prepare only the manifest, but also the dependencies withdbt deps
DagstetDbtManifestPreparer
andDbtManifestPreparer
would stay experimentalare to be renamed in another PR.Before being merged, these changes should be thoroughly discussed.
How I Tested These Changes
BK with already existing tests