[DbtProject] Remove experimental marker from DbtProject and preparer classes #22578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maximearmstrong and the rest of your teammates on |
maximearmstrong
changed the title
maximearmstrong
force-pushed
the
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
branch
from
38026a4 to
f64c377
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
4559a88 to
4b86bef
Compare
3 tasks
maximearmstrong
force-pushed
the
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
branch
from
f64c377 to
018aeac
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
4b86bef to
619c751
Compare
maximearmstrong
force-pushed
the
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
branch
from
018aeac to
3a9ab61
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
619c751 to
72b8f4b
Compare
maximearmstrong
force-pushed
the
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
branch
from
3a9ab61 to
c6732c3
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
72b8f4b to
b1a7b02
Compare
maximearmstrong
force-pushed
the
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
branch
from
c6732c3 to
3f26d2c
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
b1a7b02 to
f5bd829
Compare
maximearmstrong
force-pushed
the
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
branch
from
3f26d2c to
5ec6586
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
f5bd829 to
cae40df
Compare
maximearmstrong
force-pushed
the
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
branch
from
5ec6586 to
071e8e6
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
2 times, most recently
from
cf2a195 to
8e76f33
Compare
maximearmstrong
changed the base branch from
maxime/ds-314/add-docstring-for-dbtmanifestpreparer
to
maxime/dbt-project-rename-preparer-classes
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-ar557h0ae-elementl.vercel.app Direct link to changed pages: |
maximearmstrong
force-pushed
the
maxime/dbt-project-rename-preparer-classes
branch
from
3f389c0 to
aaa4f63
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
8e76f33 to
a871acc
Compare
maximearmstrong
force-pushed
the
maxime/dbt-project-rename-preparer-classes
branch
from
aaa4f63 to
219556c
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
a871acc to
b9eb62a
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
7614add to
e1da936
Compare
maximearmstrong
force-pushed
the
maxime/dbt-project-rename-preparer-classes
branch
from
981c904 to
37b0e1e
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
e1da936 to
cc16cb7
Compare
maximearmstrong
changed the title
sryza
approved these changes
Jun 26, 2024
maximearmstrong
force-pushed
the
maxime/dbt-project-rename-preparer-classes
branch
from
37b0e1e to
5d05e0f
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
8db03e0 to
cc74cb5
Compare
maximearmstrong
force-pushed
the
maxime/dbt-project-rename-preparer-classes
branch
from
5d05e0f to
0602367
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
cc74cb5 to
c38a110
Compare
maximearmstrong
force-pushed
the
maxime/dbt-project-rename-preparer-classes
branch
from
0602367 to
588bcd9
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
c38a110 to
e5c3da0
Compare
maximearmstrong
force-pushed
the
maxime/dbt-project-rename-preparer-classes
branch
from
588bcd9 to
34087d8
Compare
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
3 times, most recently
from
65216f6 to
2fddf4f
Compare
Base automatically changed from
maxime/dbt-project-rename-preparer-classes
to
master
June 27, 2024 18:25
maximearmstrong
force-pushed
the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
from
2fddf4f to
3872265
Compare
maximearmstrong
deleted the
maxime/ds-313/remove-experimental-tag-for-dbtproject
branch
maximearmstrong
added a commit
that referenced
this pull request
Jul 2, 2024
…bt-project` in dbt scaffold CLI (#22794) ## Summary & Motivation This PR renames the `--use-experimental-dbt-project` flag to `--use-dbt-project` in the dbt scaffold CLI, now that [DbtProject is no more experimental](#22578). This is the first step in making DbtProject the default and only strategy when scaffolding a dbt project. The goal is to facilitate the transition from the previous default strategy to that of DbtProject in our tutorials, courses and docs. Once this is merged, next steps will be to - update tutorials, courses and docs to use DbtProject. - Since our examples heavily rely on the scaffold command, we'll be able to use `dagster-dbt project scaffold --use-dbt-project` with the updated flag - make the DbtProject strategy the default and only one when using `dagster-dbt project scaffold` - update tutorials, courses and docs to remove the flag Tickets are listed [here](https://linear.app/dagster-labs/issue/DS-337/make-dbtproject-the-default-scaffold-strategy). ## How I Tested These Changes BK with updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Removes experimental marker from DbtProject,
DbtProjectPreparerandDagsterDbtProjectPreparer.How I Tested These Changes
Tested locally and no more experimental warnings for DbtProject.