[dagster-airlift] improve unit test speed #23324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 29, 2024
dpeng817
changed the title
dpeng817
changed the title
dpeng817
force-pushed
the
dpeng817/fix_tests
branch
from
eec0f12 to
6a7ab7b
Compare
This was referenced Jul 31, 2024
schrockn
requested changes
Aug 2, 2024
There was a problem hiding this comment.
As long as we are restructuring tests, I think we should have a top-level "integration_tests" folder and "unit_tests" folder right under "dagster_airlift_tests".
During active development I would like to be able to quickly run "unit_tests" without spinning up a bunch of custom infra and that instead relies on fakes or whatever.
schrockn
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves shared implementation to a shared fixture directory, and switches how we determine when airflow is stood up. This speeds up tests to take a few seconds instead of >20 minutes.