[dagster-airlift] AirflowInstance #23343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2024
dpeng817
changed the title
This was referenced Aug 1, 2024
schrockn
approved these changes
Aug 2, 2024
| return session | ||
|
|
||
|
|
||
| class AirflowInstance(NamedTuple): |
There was a problem hiding this comment.
seems a little goofy to have this be a NamedTuple but nbd
There was a problem hiding this comment.
what's goofy about it being a namedtuple? I guess just vs a regular class you mean?
Honestly it's just learned behavior from the codebase at this point
There was a problem hiding this comment.
Generally NamedTuple are "dumb" value objects that represent a value/record at a point in time. This is a more complex object that will likely accumulate state, require caching, that sort of thing.
This was referenced Aug 2, 2024
Base automatically changed from
dpeng817/fix_materialization_reporting_order
to
master
August 3, 2024 23:52
dpeng817
force-pushed
the
dpeng817/factor_out_instance
branch
from
fa5a0dd to
264168d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AirflowInstance API, which vends out access to the airflow rest API.
This paves the way for having multiple auth backends supporting airlift utilities. Also just happens to feel nicer api-wise.