Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials to remove Dagster code from __init__.py (code) #23346

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jul 31, 2024

Summary & Motivation

This PR updates tutorial examples to remove Dagster code from __init__.py:

  • tutorial
  • tutorial_notebook_assets

How I Tested These Changes

Deployed locally
BK with existing tests

@maximearmstrong maximearmstrong changed the title Update tutorials to remove Dagster code from __init¨__.py (code) Update tutorials to remove Dagster code from __init__.py (code) Jul 31, 2024
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from a12a661 to c5f5418 Compare July 31, 2024 15:14
@maximearmstrong maximearmstrong force-pushed the maxime/ds-386/update-tutorials-to-remove-dagster-code-from-init-py branch from a7c7f7b to 1ea4d66 Compare July 31, 2024 15:14
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from c5f5418 to 2124dff Compare July 31, 2024 15:23
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch 2 times, most recently from b687189 to 2796daf Compare July 31, 2024 17:20
@maximearmstrong maximearmstrong force-pushed the maxime/ds-386/update-tutorials-to-remove-dagster-code-from-init-py branch from 1ea4d66 to 8418157 Compare July 31, 2024 17:20
@maximearmstrong maximearmstrong self-assigned this Aug 1, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review August 1, 2024 13:33
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 2796daf to 16994c5 Compare August 1, 2024 13:38
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 1, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 August 1, 2024 13:38
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 16994c5 to 24ac6a8 Compare August 5, 2024 21:27
@maximearmstrong maximearmstrong force-pushed the maxime/ds-386/update-tutorials-to-remove-dagster-code-from-init-py branch from 8418157 to 553dcf5 Compare August 5, 2024 21:27
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 24ac6a8 to 6b0ba2b Compare August 13, 2024 13:14
@maximearmstrong maximearmstrong force-pushed the maxime/ds-386/update-tutorials-to-remove-dagster-code-from-init-py branch from 553dcf5 to 783bc98 Compare August 13, 2024 13:14
Base automatically changed from maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init to master August 13, 2024 13:38
@maximearmstrong maximearmstrong force-pushed the maxime/ds-386/update-tutorials-to-remove-dagster-code-from-init-py branch from 783bc98 to 07745f2 Compare August 13, 2024 13:49
@maximearmstrong maximearmstrong merged commit d487c27 into master Aug 13, 2024
1 check passed
@maximearmstrong maximearmstrong deleted the maxime/ds-386/update-tutorials-to-remove-dagster-code-from-init-py branch August 13, 2024 14:03
maximearmstrong added a commit that referenced this pull request Aug 13, 2024
…cs) (#23347)

## Summary & Motivation

This PR updates the tutorial docs to match the file structure updated in
#23346

## How I Tested These Changes

docs preview
PedramNavid pushed a commit that referenced this pull request Aug 14, 2024
…3346)

## Summary & Motivation

This PR updates tutorial examples to remove Dagster code from
`__init__.py`:
- tutorial
- tutorial_notebook_assets

## How I Tested These Changes

Deployed locally
BK with existing tests
PedramNavid pushed a commit that referenced this pull request Aug 14, 2024
…cs) (#23347)

## Summary & Motivation

This PR updates the tutorial docs to match the file structure updated in
#23346

## How I Tested These Changes

docs preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants