-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update URL to Definitions for project-fully-featured #23350
Merged
maximearmstrong
merged 1 commit into
master
from
maxime/fix-project-fully-featured-url-in-structure-guide
Aug 13, 2024
Merged
[docs] Update URL to Definitions for project-fully-featured #23350
maximearmstrong
merged 1 commit into
master
from
maxime/fix-project-fully-featured-url-in-structure-guide
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maximearmstrong and the rest of your teammates on Graphite |
This was referenced Jul 31, 2024
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-l28mnhabq-elementl.vercel.app Direct link to changed pages: |
maximearmstrong
force-pushed
the
maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init
branch
from
July 31, 2024 15:59
2124dff
to
b687189
Compare
maximearmstrong
force-pushed
the
maxime/fix-project-fully-featured-url-in-structure-guide
branch
from
July 31, 2024 15:59
5de3926
to
3939051
Compare
maximearmstrong
force-pushed
the
maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init
branch
2 times, most recently
from
August 1, 2024 13:38
2796daf
to
16994c5
Compare
maximearmstrong
force-pushed
the
maxime/fix-project-fully-featured-url-in-structure-guide
branch
from
August 1, 2024 13:38
3939051
to
1e384c9
Compare
maximearmstrong
changed the title
[docs] Update URL to project-fully-featured Definitions
[docs] Update URL to Definitions for project-fully-featured
Aug 1, 2024
maximearmstrong
force-pushed
the
maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init
branch
from
August 5, 2024 21:27
16994c5
to
24ac6a8
Compare
maximearmstrong
force-pushed
the
maxime/fix-project-fully-featured-url-in-structure-guide
branch
from
August 5, 2024 21:27
1e384c9
to
597f9bd
Compare
cmpadden
approved these changes
Aug 7, 2024
maximearmstrong
force-pushed
the
maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init
branch
from
August 13, 2024 13:14
24ac6a8
to
6b0ba2b
Compare
maximearmstrong
force-pushed
the
maxime/fix-project-fully-featured-url-in-structure-guide
branch
from
August 13, 2024 13:14
597f9bd
to
ad06927
Compare
Base automatically changed from
maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init
to
master
August 13, 2024 13:38
maximearmstrong
force-pushed
the
maxime/fix-project-fully-featured-url-in-structure-guide
branch
from
August 13, 2024 13:39
ad06927
to
04861df
Compare
maximearmstrong
deleted the
maxime/fix-project-fully-featured-url-in-structure-guide
branch
August 13, 2024 13:48
PedramNavid
pushed a commit
that referenced
this pull request
Aug 14, 2024
## Summary & Motivation This PR updates the URL to the file containing Definitions in project-fully-featured. That was moved from #23316 to this PR to avoid failure when running the doc tests - the file must exist before being referenced, and it is updated in #23345. ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR updates the URL to the file containing Definitions in project-fully-featured. That was moved from #23316 to this PR to avoid failure when running the doc tests - the file must exist before being referenced, and it is updated in #23345.
How I Tested These Changes
BK