Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update URL to Definitions for project-fully-featured #23350

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jul 31, 2024

Summary & Motivation

This PR updates the URL to the file containing Definitions in project-fully-featured. That was moved from #23316 to this PR to avoid failure when running the doc tests - the file must exist before being referenced, and it is updated in #23345.

How I Tested These Changes

BK

Copy link
Contributor Author

maximearmstrong commented Jul 31, 2024

@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 2124dff to b687189 Compare July 31, 2024 15:59
@maximearmstrong maximearmstrong force-pushed the maxime/fix-project-fully-featured-url-in-structure-guide branch from 5de3926 to 3939051 Compare July 31, 2024 15:59
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch 2 times, most recently from 2796daf to 16994c5 Compare August 1, 2024 13:38
@maximearmstrong maximearmstrong force-pushed the maxime/fix-project-fully-featured-url-in-structure-guide branch from 3939051 to 1e384c9 Compare August 1, 2024 13:38
@maximearmstrong maximearmstrong changed the title [docs] Update URL to project-fully-featured Definitions [docs] Update URL to Definitions for project-fully-featured Aug 1, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review August 1, 2024 13:42
@maximearmstrong maximearmstrong self-assigned this Aug 1, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 August 1, 2024 13:42
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 1, 2024
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 16994c5 to 24ac6a8 Compare August 5, 2024 21:27
@maximearmstrong maximearmstrong force-pushed the maxime/fix-project-fully-featured-url-in-structure-guide branch from 1e384c9 to 597f9bd Compare August 5, 2024 21:27
@maximearmstrong maximearmstrong requested a review from sryza August 7, 2024 17:04
@maximearmstrong maximearmstrong force-pushed the maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init branch from 24ac6a8 to 6b0ba2b Compare August 13, 2024 13:14
@maximearmstrong maximearmstrong force-pushed the maxime/fix-project-fully-featured-url-in-structure-guide branch from 597f9bd to ad06927 Compare August 13, 2024 13:14
Base automatically changed from maxime/ds-387/update-project-examples-to-remove-dagster-code-from-init to master August 13, 2024 13:38
@maximearmstrong maximearmstrong force-pushed the maxime/fix-project-fully-featured-url-in-structure-guide branch from ad06927 to 04861df Compare August 13, 2024 13:39
@maximearmstrong maximearmstrong merged commit 2ef4f25 into master Aug 13, 2024
2 checks passed
@maximearmstrong maximearmstrong deleted the maxime/fix-project-fully-featured-url-in-structure-guide branch August 13, 2024 13:48
PedramNavid pushed a commit that referenced this pull request Aug 14, 2024
## Summary & Motivation

This PR updates the URL to the file containing Definitions in
project-fully-featured. That was moved from #23316 to this PR to avoid
failure when running the doc tests - the file must exist before being
referenced, and it is updated in #23345.

## How I Tested These Changes

BK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants