take storage_kind label off the asset node #23371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 19da658. |
sryza
force-pushed
the
rm-storage-kind-from-node
branch
from
638a4c1 to
477ea20
Compare
sryza
force-pushed
the
rm-storage-kind-from-node
branch
from
b0debf4 to
f98d8b4
Compare
sryza
force-pushed
the
rm-storage-kind-from-node
branch
from
f98d8b4 to
19da658
Compare
jmsanders
pushed a commit
that referenced
this pull request
Aug 5, 2024
## Summary & Motivation This turned out controversial, because of the alternative of introducing a new `kinds` attribute. So walking this back. ## How I Tested These Changes (cherry picked from commit ce26af9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This turned out controversial, because of the alternative of introducing a new
kindsattribute. So walking this back.How I Tested These Changes