Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't propagate click events from popover + remove unnecessary overflow hidden #23443

Merged
merged 2 commits into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ export const ProductTour = ({
}}
minimal={false}
content={
<>
<div
onClick={(ev) => {
ev.stopPropagation();
}}
>
<div />
<ProductTourContainer flex={{direction: 'column', gap: 4}} padding={16} style={{width}}>
<Box flex={{direction: 'column', gap: 8}}>
Expand All @@ -95,7 +99,7 @@ export const ProductTour = ({
{actionsJsx}
</ProductTourContainer>
<div />
</>
</div>
}
>
{children}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,7 @@ export const AssetPageHeader = ({
return (
<PageHeader
title={
<Box
flex={{alignItems: 'center', gap: 4}}
style={{maxWidth: '600px', overflow: 'hidden', marginBottom: 4}}
>
<Box flex={{alignItems: 'center', gap: 4}} style={{maxWidth: '600px', marginBottom: 4}}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - verified this wasn't from Dish's latest PR about the truncating breadcrumbs, so it seems fine to remove to me 👍

<Title>
<BreadcrumbsWithSlashes
items={breadcrumbs}
Expand Down