Don't propagate click events from popover + remove unnecessary overflow hidden #23443
Conversation
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit c953085. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit c953085. |
What happens in this case when the event bubbles up? Is there some unexpected behavior?
Can you share a screenshot of what this looks like? I'm not sure I'm visualizing it correctly. |
So the product tour has a "Dismiss button" and when you click it, the click event propagates up to the button that the popover is wrapping which ends up causing the popover on the button to fire. It might be an issue due to have two popovers...
|
| flex={{alignItems: 'center', gap: 4}} | ||
| style={{maxWidth: '600px', overflow: 'hidden', marginBottom: 4}} | ||
| > | ||
| <Box flex={{alignItems: 'center', gap: 4}} style={{maxWidth: '600px', marginBottom: 4}}> |
There was a problem hiding this comment.
Interesting - verified this wasn't from Dish's latest PR about the truncating breadcrumbs, so it seems fine to remove to me 👍
…ow hidden (#23443) ## Summary & Motivation 1. Don't propagate click events from the popover of ProductTour since by default blueprint's `Popover` seems to bubble them up to the element its wrapping (super weird!). 2. Remove overflow: hidden from the AssetPageHeader because this wraps a button that uses outerglow on hover and the overflow hidden ends up hiding the outerglow making it look weird. (cherry picked from commit f3ce9a8)
Summary & Motivation
Popoverseems to bubble them up to the element its wrapping (super weird!).