Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/revamp #23530

Closed
wants to merge 10 commits into from
Closed

Docs/revamp #23530

wants to merge 10 commits into from

Conversation

PedramNavid
Copy link
Contributor

Summary & Motivation

How I Tested These Changes

@PedramNavid PedramNavid force-pushed the docs/revamp branch 3 times, most recently from 0e42d65 to 95c2cf6 Compare August 8, 2024 21:41
Copy link

github-actions bot commented Aug 8, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-7ob7nywzg-elementl.vercel.app
https://docs-revamp.dagster.dagster-docs.io

Direct link to changed pages:

@PedramNavid PedramNavid force-pushed the docs/revamp branch 4 times, most recently from 637707c to 805b36a Compare August 9, 2024 22:02
Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dagster-docs-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 7:41pm

Copy link

netlify bot commented Aug 11, 2024

Deploy Preview for dagsterapidocs failed.

Name Link
🔨 Latest commit a1e46b0
🔍 Latest deploy log https://app.netlify.com/sites/dagsterapidocs/deploys/66c511dc0213e70008c367c8

Copy link

github-actions bot commented Aug 13, 2024

Deploy preview for dagster-docs-next ready!

✅ Preview
https://dagster-docs-next-fbyub66tq-elementl.vercel.app

Built with commit e1e2eff.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Aug 19, 2024

Deploy preview for dagster-docs-beta ready!

✅ Preview
https://dagster-docs-beta-759p92p2m-elementl.vercel.app

Built with commit 8de4fa2.
This pull request is being automatically deployed with vercel-action

@PedramNavid
Copy link
Contributor Author

lgtm

PedramNavid added a commit that referenced this pull request Aug 20, 2024
## Summary & Motivation

This adds the new beta docs site into our main repo. This is still a
work in progress and does not affect the deployment of our existing docs. This
work was originally undertaken in the #23530 branch, however, I have
brought it in as a squashed self-contained PR to keep the history clean.

## How I Tested These Changes

Built locally, BK, and Vercel.

---------

Co-authored-by: colton <[email protected]>
## Summary & Motivation

This PR beefs up our Vale implementation with some custom rules and
vocabularies. The README for this will be updated in a subsequent PR.

## How I Tested These Changes

eyes, local
## Summary & Motivation

This PR addresses comments in #23754 

## How I Tested These Changes
PedramNavid and others added 6 commits August 20, 2024 21:44
## Summary & Motivation

Misspelling in readme.

## How I Tested These Changes

N/A
Brings in #23754 and #23758 into the master branch for docs-beta
styling.

---------

Co-authored-by: Erin Cochran <[email protected]>
We shouldn't have `.yarn/install-state.gz` checked in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants