[dagster-airlift] AirflowInstance, sensor refactor #23538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpeng817
changed the title
schrockn
reviewed
Aug 9, 2024
|
|
||
| @property | ||
| def end_date(self) -> float: | ||
| return AirflowInstance.timestamp_from_airflow_date(self.metadata["end_date"]) |
There was a problem hiding this comment.
At some point we might cross the threshold of wanting to use an openapi-generated client https://github.com/apache/airflow-client-python
schrockn
approved these changes
Aug 9, 2024
dpeng817
force-pushed
the
dpeng817/cacheable_assets_transitive
branch
from
7ffd167 to
e9f5927
Compare
dpeng817
force-pushed
the
dpeng817/airflow_instance_fixes
branch
from
7a2a739 to
f497897
Compare
dpeng817
force-pushed
the
dpeng817/cacheable_assets_transitive
branch
from
e9f5927 to
f692103
Compare
dpeng817
force-pushed
the
dpeng817/airflow_instance_fixes
branch
from
f497897 to
d6d0f56
Compare
This was referenced Aug 9, 2024
dpeng817
force-pushed
the
dpeng817/airflow_instance_fixes
branch
from
d6d0f56 to
5a69ee2
Compare
…well-typed properties
dpeng817
force-pushed
the
dpeng817/airflow_instance_fixes
branch
from
5a69ee2 to
bc014a2
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Aug 9, 2024
Made the AirflowInstance vended classes more composable so we're not throwing around raw dicts everywhere. Added some utilities to trigger and wait for the completion of airflow runs, which are used in tests (for now...) Made some refactors to the sensor after realizing we don't actually want to report in topological order... we want to report in task order. So instead, retrieve per-task info about each execution. Better testing of this new method is forthcoming, but existing tests already exercise the codepath.
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the AirflowInstance vended classes more composable so we're not throwing around raw dicts everywhere. Added some utilities to trigger and wait for the completion of airflow runs, which are used in tests (for now...)
Made some refactors to the sensor after realizing we don't actually want to report in topological order... we want to report in task order. So instead, retrieve per-task info about each execution. Better testing of this new method is forthcoming, but existing tests already exercise the codepath.