Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-airlift] peer/observe/migrate for dbt example #23614

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dpeng817
Copy link
Contributor

@dpeng817 dpeng817 commented Aug 13, 2024

I think it's valuable to show what the POM steps look like in isolation, so I created separate makefile commands + python targets to run each of them.

@dpeng817 dpeng817 marked this pull request as ready for review August 13, 2024 16:44
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch from bef515d to 1e8778b Compare August 13, 2024 17:34
@dpeng817 dpeng817 changed the base branch from dpeng817/new_operator_lakehouse to dpeng817/fix_dbt_defs_params August 13, 2024 17:34
@dpeng817 dpeng817 force-pushed the dpeng817/fix_dbt_defs_params branch from 4242bc9 to 4d7e546 Compare August 13, 2024 18:01
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch from 1e8778b to c244c8f Compare August 13, 2024 18:01
Copy link
Member

@benpankow benpankow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is very illustrative

@dpeng817 dpeng817 force-pushed the dpeng817/fix_dbt_defs_params branch from 4d7e546 to c5b4f80 Compare August 13, 2024 20:53
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch from c244c8f to ffddbdd Compare August 13, 2024 20:53
@dpeng817 dpeng817 force-pushed the dpeng817/fix_dbt_defs_params branch from c5b4f80 to b9805d6 Compare August 13, 2024 21:14
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch from ffddbdd to 10298f3 Compare August 13, 2024 21:14
@dpeng817 dpeng817 force-pushed the dpeng817/fix_dbt_defs_params branch from b9805d6 to 7be18e9 Compare August 13, 2024 21:45
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch 2 times, most recently from 424a9bf to 0cfbc7b Compare August 13, 2024 21:58
@dpeng817 dpeng817 force-pushed the dpeng817/fix_dbt_defs_params branch from 7be18e9 to d3b9399 Compare August 13, 2024 22:11
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch from 0cfbc7b to 57cb882 Compare August 13, 2024 22:11
@dpeng817 dpeng817 force-pushed the dpeng817/fix_dbt_defs_params branch from d3b9399 to 723face Compare August 13, 2024 22:13
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch from 57cb882 to fcc9e73 Compare August 13, 2024 22:14
@dpeng817 dpeng817 force-pushed the dpeng817/fix_dbt_defs_params branch from 723face to 38b3a1c Compare August 13, 2024 22:19
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch 2 times, most recently from 6f05854 to cd64ef3 Compare August 13, 2024 22:43
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch 2 times, most recently from 2b0d128 to 8c2f0eb Compare August 13, 2024 23:27
Base automatically changed from dpeng817/fix_dbt_defs_params to master August 14, 2024 16:20
@dpeng817 dpeng817 force-pushed the dpeng817/pom_dbt_example branch from 8c2f0eb to 11e769a Compare August 21, 2024 15:19
@dpeng817 dpeng817 merged commit 588e8eb into master Aug 21, 2024
1 check was pending
@dpeng817 dpeng817 deleted the dpeng817/pom_dbt_example branch August 21, 2024 15:25
cmpadden pushed a commit that referenced this pull request Aug 21, 2024
I think it's valuable to show what the POM steps look like in isolation,
so I created separate makefile commands + python targets to run each of
them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants