Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Filter hidden definitions tags #23771

Closed
wants to merge 4 commits into from
Closed

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Aug 20, 2024

Summary

For run tags, we identify three tag types:

  • User-defined tags, which users can attach to their jobs and which flow through to runs of those jobs
  • System tags, which Dagster attaches to runs, signaled by the dagster/ prefix
  • Hidden tags, which do not appear in the UI, signaled by the .dagster/ prefix

For asset definition tags, we already use the dagster/ prefix as a form of "namespacing", but no asset definition tags match the run-tag notion of "system tags."
Still, it would be useful to have a set of asset definition tags we hide from the UI entirely for things like the kind system.

This PR introduces the .dagster/ prefix as a hidden tag indicator for the definition tag system. These tags are filtered out on the frontend from display.

Test Plan

Tested locally

@benpankow
Copy link
Member Author

benpankow commented Aug 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

@benpankow benpankow requested review from sryza and schrockn August 20, 2024 21:00
@benpankow benpankow force-pushed the benpankow/def-tags-hidden branch from f1492cb to 50ffeee Compare August 20, 2024 21:00
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this compare so the system tags that happen on materializations? Right now we hide those from the UI by default, for example. I think the treatment should uniform between tags here and tags there.

@benpankow
Copy link
Member Author

How does this compare so the system tags that happen on materializations? Right now we hide those from the UI by default, for example. I think the treatment should uniform between tags here and tags there.

Are you talking about this toggle?
Screenshot 2024-08-20 at 2 31 42 PM

As far as I can tell that's all handled on the frontend - the backend doesn't handle system tags differently with the sole exception that we don't validate them:
https://github.com/dagster-io/dagster/blob/master/python_modules/dagster/dagster/_core/definitions/events.py#L763

@schrockn
Copy link
Member

Why don't we just do the same here for now?

@benpankow
Copy link
Member Author

At second blush I'm not convinced there's a reason to thread this through tags - see #23778

@benpankow benpankow force-pushed the benpankow/def-tags-hidden branch from 50ffeee to f73cb45 Compare August 20, 2024 23:43
@benpankow benpankow force-pushed the benpankow/def-tags-hidden branch 2 times, most recently from 57b0401 to 4a4518a Compare August 21, 2024 18:02
Copy link

github-actions bot commented Aug 21, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-fe9ju93r8-elementl.vercel.app
https://benpankow-def-tags-hidden.core-storybook.dagster-docs.io

Built with commit cd640da.
This pull request is being automatically deployed with vercel-action

@schrockn
Copy link
Member

I'm still not convinced we need this.

@benpankow benpankow force-pushed the benpankow/def-tags-hidden branch from 8426cf3 to cd640da Compare August 23, 2024 23:00
@benpankow benpankow changed the title Introduce notion of hidden definitions tags [ui] Filter hidden definitions tags Aug 23, 2024
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queue mgmt. I'm still not sold on supporting hidden tags like this. We should discuss.

@benpankow benpankow closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants