[ui] Replace compute kind, storage kind filters + tags with generic kind #23805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit de5fd89. |
benpankow
force-pushed
the
benpankow/kind-specs-2
branch
from
eee4bd6 to
dc901b6
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
2 times, most recently
from
954290e to
20f596c
Compare
benpankow
changed the base branch from
benpankow/kind-specs-2
to
benpankow/strip-storage-kind
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
93eab68 to
c8e8f0e
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
20f596c to
0221c00
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
c8e8f0e to
841f271
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
0221c00 to
c513640
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
841f271 to
4621a59
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
c513640 to
a5ba3ac
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
4621a59 to
15ba582
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
a5ba3ac to
34df0c8
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
15ba582 to
fac926c
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
34df0c8 to
79e7389
Compare
hellendag
approved these changes
Aug 23, 2024
| .filter((o) => o) | ||
| .flatMap((a) => a as string[]), | ||
| ), | ||
| ).sort(), |
There was a problem hiding this comment.
I think you can just do this:
Array.from(
new Set(assets.map((a) => a?.definition?.kinds || []).flat())
).sort(...);
Also, it's generally good to use this to ensure a reliable string sort:
.sort((a, b) => COMMON_COLLATOR.compare(a, b))
fac926c to
2ce7807
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
79e7389 to
8a98eb6
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
2ce7807 to
77fc7ec
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
8a98eb6 to
a80d4e0
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
77fc7ec to
08ee3e9
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
a80d4e0 to
dd71cda
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
08ee3e9 to
96207b3
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
dd71cda to
d0c68c4
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
96207b3 to
1e9e28c
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
d0c68c4 to
c6c941a
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
1e9e28c to
455f2e8
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
c6c941a to
dfe241f
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
455f2e8 to
02120fb
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
dfe241f to
35f0eb4
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
02120fb to
e074331
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
35f0eb4 to
166d0fd
Compare
benpankow
force-pushed
the
benpankow/strip-storage-kind
branch
from
e074331 to
403be73
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
2 times, most recently
from
56e97bc to
5382818
Compare
benpankow
force-pushed
the
benpankow/kinds-ui
branch
from
5382818 to
de5fd89
Compare
benpankow
changed the base branch from
benpankow/strip-storage-kind
to
graphite-base/23805
benpankow
added a commit
that referenced
this pull request
Sep 9, 2024
## Summary Re-implementation of #23805 which is slightly lighter weight (but still touches a lot of surface area). Substitutes in the notion of a generic kind filter rather than specifically compute kind. ## Test Plan Existing unit tests, local dagit. ## Changelog `NOCHANGELOG`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we move to 'kind' being a first class notion, with multiple potential values, this PR tears out the compute kind and storage kind filters and UI components and drops in a singular 'kind' replacement, backed by the
kindsGQL endpoint.Test Plan
Tested locally, few new unit tests.