Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Further remove references to storage kind #24130

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Aug 30, 2024

Summary

More cleanup - will be stacked with above PR and an internal companion
https://github.com/dagster-io/internal/pull/11269

@benpankow
Copy link
Member Author

benpankow commented Aug 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benpankow and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Aug 30, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-6hg1l493y-elementl.vercel.app
https://benpankow-strip-storage-kind-2.core-storybook.dagster-docs.io

Built with commit 4df4a02.
This pull request is being automatically deployed with vercel-action

@benpankow benpankow force-pushed the benpankow/strip-storage-kind-2 branch from 1fdc203 to 23a6ceb Compare August 30, 2024 23:36
@benpankow benpankow force-pushed the benpankow/strip-storage-kind branch from 1e9e28c to 455f2e8 Compare August 30, 2024 23:45
@benpankow benpankow force-pushed the benpankow/strip-storage-kind-2 branch from 23a6ceb to 902ca5b Compare August 30, 2024 23:45
@benpankow benpankow force-pushed the benpankow/strip-storage-kind branch from 455f2e8 to 02120fb Compare September 2, 2024 17:24
@benpankow benpankow force-pushed the benpankow/strip-storage-kind-2 branch from 902ca5b to 1b7ba68 Compare September 2, 2024 17:25
@benpankow benpankow force-pushed the benpankow/strip-storage-kind branch from 02120fb to e074331 Compare September 2, 2024 18:26
@benpankow benpankow force-pushed the benpankow/strip-storage-kind-2 branch from 1b7ba68 to dcc2581 Compare September 2, 2024 18:26
@benpankow benpankow force-pushed the benpankow/strip-storage-kind branch from e074331 to 403be73 Compare September 2, 2024 18:34
@benpankow benpankow force-pushed the benpankow/strip-storage-kind-2 branch 3 times, most recently from 79653a0 to 50716cd Compare September 2, 2024 18:54
@benpankow
Copy link
Member Author

benpankow commented Sep 2, 2024

Merge activity

  • Sep 2, 12:13 PM PDT: @benpankow started a stack merge that includes this pull request via Graphite.
  • Sep 2, 12:16 PM PDT: Graphite rebased this pull request as part of a merge.
  • Sep 2, 12:17 PM PDT: @benpankow merged this pull request with Graphite.

@benpankow benpankow changed the base branch from benpankow/strip-storage-kind to graphite-base/24130 September 2, 2024 19:14
@benpankow benpankow changed the base branch from graphite-base/24130 to master September 2, 2024 19:14
@benpankow benpankow force-pushed the benpankow/strip-storage-kind-2 branch from 50716cd to 4df4a02 Compare September 2, 2024 19:15
@benpankow benpankow merged commit 9b9b968 into master Sep 2, 2024
1 of 2 checks passed
@benpankow benpankow deleted the benpankow/strip-storage-kind-2 branch September 2, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants