[2/k][ui] Replace compute kind filters with kind filters #24160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 0e0981d. |
benpankow
force-pushed
the
benpankow/kinds-ui-1
branch
from
8dcf5cd to
6e6b2eb
Compare
benpankow
force-pushed
the
benpankow/kinds-ui-2
branch
from
aa198f9 to
05dc5fe
Compare
benpankow
changed the base branch from
benpankow/kinds-ui-1
to
graphite-base/24160
benpankow
force-pushed
the
graphite-base/24160
branch
from
6e6b2eb to
5d3c50a
Compare
benpankow
force-pushed
the
benpankow/kinds-ui-2
branch
from
05dc5fe to
37e8e7a
Compare
benpankow
force-pushed
the
benpankow/kinds-ui-2
branch
2 times, most recently
from
dc2569d to
84f0c61
Compare
salazarm
reviewed
Sep 5, 2024
Comment on lines
78
to
100
|
|
||
| export function useAssetTagsForAssets( | ||
| assets: {definition?: {tags?: DefinitionTag[] | null} | null}[], | ||
| ): DefinitionTag[] { | ||
| return useMemo( | ||
| () => | ||
| Array.from( | ||
| new Set( | ||
| assets | ||
| .flatMap((a) => a.definition?.tags?.map((tag) => JSON.stringify(tag)) ?? []) | ||
| .filter((o) => o), | ||
| ), | ||
| ) | ||
| .map((jsonTag) => buildDefinitionTag(JSON.parse(jsonTag))) | ||
| .sort((a, b) => | ||
| // Sort by key then by value | ||
| a.key.localeCompare(b.key) === 0 | ||
| ? a.value.localeCompare(b.value) | ||
| : a.key.localeCompare(b.key), | ||
| ), | ||
| [assets], | ||
| ); | ||
| } |
There was a problem hiding this comment.
I don't see any changes here?
salazarm
reviewed
Sep 5, 2024
| @@ -152,7 +152,6 @@ export function useAssetCatalogFiltering< | |||
| [ | |||
| ['owners', filters.owners, allAssetOwners] as const, | |||
| ['tags', filters.tags, tags] as const, | |||
| ['kinds', filters.kinds, allKinds] as const, | |||
salazarm
approved these changes
Sep 5, 2024
benpankow
force-pushed
the
benpankow/kinds-ui-2
branch
2 times, most recently
from
599c205 to
f803e74
Compare
This was referenced Sep 6, 2024
benpankow
force-pushed
the
benpankow/kinds-ui-2
branch
from
f803e74 to
0e0981d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-implementation of #23805 which is slightly lighter weight (but still touches a lot of surface area). Substitutes in the notion of a generic kind filter rather than specifically compute kind.
Test Plan
Existing unit tests, local dagit.
Changelog
NOCHANGELOG