[1/k][ui] Pull, display generic kinds in place of compute kind #24159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
This was referenced Sep 2, 2024
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 8637118. |
salazarm
reviewed
Sep 3, 2024
| @@ -10,11 +10,15 @@ export const LEGACY_COMPUTE_KIND_TAG = 'kind'; | |||
| export const COMPUTE_KIND_TAG = 'dagster/compute_kind'; | |||
| export const STORAGE_KIND_TAG = 'dagster/storage_kind'; | |||
|
|
|||
| export const KIND_TAG_PREFIX = `dagster/kind/`; | |||
There was a problem hiding this comment.
You could define this here: https://github.com/dagster-io/dagster/blob/master/js_modules/dagster-ui/packages/ui-core/src/runs/RunTag.tsx#L7
salazarm
approved these changes
Sep 3, 2024
benpankow
force-pushed
the
benpankow/kind-specs-2
branch
from
01672e2 to
c734909
Compare
benpankow
force-pushed
the
benpankow/kinds-ui-1
branch
from
8dcf5cd to
6e6b2eb
Compare
Merge activity
|
benpankow
changed the base branch from
benpankow/kind-specs-2
to
graphite-base/24159
benpankow
force-pushed
the
benpankow/kinds-ui-1
branch
from
6e6b2eb to
8637118
Compare
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Begin moving from compute kinds to kinds by requesting the list of kinds from GraphQL (introduced in #24154, a superset of the compute kind) and then displaying those in place of the compute kind tags in the asset graph and asset list.
Changelog
NOCHANGELOG