[docs-beta] Use yarn #23774
Closed
[docs-beta] Use yarn #23774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary & Motivation ## How I Tested These Changes
…nto docs/revamp
## Summary & Motivation This PR beefs up our Vale implementation with some custom rules and vocabularies. The README for this will be updated in a subsequent PR. ## How I Tested These Changes eyes, local
## Summary & Motivation This PR addresses comments in #23754 ## How I Tested These Changes
✅ Deploy Preview for dagsterapidocs canceled.
|
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-qyu2o1fwz-elementl.vercel.app Direct link to changed pages: |
PedramNavid
reviewed
Aug 20, 2024
| It also uses [vale](https://vale.sh/) to check for issues in the documentation. | ||
|
|
||
| Install dependencies with: | ||
| Install value with: |
There was a problem hiding this comment.
Suggested change
| Install value with: | |
| Install vale with: |
PedramNavid
approved these changes
Aug 20, 2024
PedramNavid
force-pushed
the
docs/revamp
branch
from
137ed67 to
a1e46b0
Compare
|
Merged in e1745f3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Use yarn instead of pnpm for consistency with other projects in @dagster-io/dagster.
How I Tested These Changes
yarn, thenyarn start.