-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-beta] Use yarn #23774
Closed
Closed
[docs-beta] Use yarn #23774
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
cc08b37
[docs] add vale
PedramNavid 95c2cf6
add github workflow for vale
PedramNavid ec0869a
add github workflow for vale
PedramNavid dfe6b07
add basic sphinx build with html template
PedramNavid 77bbe41
add readme
PedramNavid 435044a
update pins
PedramNavid 142696d
fix tox
PedramNavid 7cbfda4
Merge branch 'master' into docs/revamp
PedramNavid b080bff
add placeholder doc string
PedramNavid 805b36a
Fix broken docs build (#23562)
PedramNavid 36da245
Merge branch 'master' into docs/revamp
PedramNavid b342c33
fix checks
PedramNavid 2231e25
update apidoc styling
PedramNavid 41d4b9a
update pyright pins
PedramNavid a95f0d6
add docusaurus
PedramNavid 8c14773
add initial docusaurus build
PedramNavid 93e68b6
improve docstring error handling
PedramNavid 019a47a
copy over existing getting started
PedramNavid 9d05960
update quickstart tutorial and add ETL tutorial
PedramNavid 7c48276
update vale
PedramNavid 9d1cf53
fix all vale errors
PedramNavid 37003d2
fix build
PedramNavid 2b2d4f5
update docusaurus port to 3050
PedramNavid b75d0d9
relax sphinx version for netlify
PedramNavid 4d5be2a
add dagster sphinx to requirements
PedramNavid 7a2f59d
add dagster as a requirement to sphinx ext
PedramNavid 14b42b9
update quick start to be more dagstonic
PedramNavid 2900524
Merge branch 'docs/revamp' of https://github.com/dagster-io/dagster i…
erinkcochran87 ac2e7e4
First pass at templates
erinkcochran87 e91e760
remove msft from vale
PedramNavid 836eab7
add raw loader for snippets
PedramNavid bc8732c
Add second guide template
erinkcochran87 879ce1d
Merge branch 'docs/revamp' of https://github.com/dagster-io/dagster i…
erinkcochran87 0976465
Update top nav; add seed pages
erinkcochran87 26cb495
update font to geist
PedramNavid ff46499
update gitignore and sidebar
PedramNavid 7b896fe
remove asset management
PedramNavid 9c16bcd
[docs] [revamp] - Add sections to Guides category (#23582)
erinkcochran87 f04bd0f
vercel docs revamp (#23595)
prha 08edae0
update dagster docs next project (#23600)
prha 07b3f19
Run on PRs to branch
PedramNavid 5c067f1
[docs] [revamp] - Seed /guides pages (#23601)
erinkcochran87 a854606
fix pyright
PedramNavid aa7cac7
[docs] [revamp] - Seed Concept pages (#23602)
erinkcochran87 9b03ed7
add tutorial
PedramNavid 387b7a5
Add Passing Data Between Assets Guide (#23598)
PedramNavid 8e8ab66
add some automation code
PedramNavid 03761f1
add placehodlers
PedramNavid c547b2d
Testing Vercel
erinkcochran87 a4963e7
First pass at Dagster+ sidebar & pages
erinkcochran87 1355aec
Fix links
erinkcochran87 354c69f
Clean up; add Serverless pages
erinkcochran87 1718a78
Docs Revamp – Set up baseline themes (#23691)
braunjj 4e1a1c9
Add Automation Page (#23659)
PedramNavid 7371e06
add Vale rules
PedramNavid ec535a4
run prettier
PedramNavid ab05fd7
run prettier
PedramNavid 41a4799
run prettier and eslint and all that stuff
PedramNavid cc544c7
fix highlight styles
PedramNavid c55b3f5
move templates to docs folder
PedramNavid 7235e58
move code examples to code_example folder
PedramNavid 2efbc13
update CodeExample to reference new folder
PedramNavid af3c47e
move content templates one folder higher
PedramNavid b43d0ec
Docs Revamp – more theme work (#23713)
braunjj e7235cc
Add automation content part 2
PedramNavid be0daa6
update concept
PedramNavid 7ec8d7b
Add readme and update package.json
PedramNavid 2c40d77
Add readme and update package.json
PedramNavid e1e2eff
fix broken build
PedramNavid 4078e89
move to docs-beta folder
PedramNavid d2a4b0b
fix broken link
PedramNavid 01d292e
update Makefile
PedramNavid 13d16fb
add visible hr
cmpadden ff98d86
Merge branch 'docs/revamp' into pdrm/automation-part-2
PedramNavid d9f5a9f
add top borders to all markdown h2 headers
cmpadden b91b5ad
h2 border color keyline
cmpadden 33b1826
update automation
PedramNavid 1942ed2
add vscode recommendations;
PedramNavid 490939a
update data modeling
PedramNavid c47dc46
update templates to match automation guide
PedramNavid d227999
add visible hr
cmpadden 765fd1f
add top borders to all markdown h2 headers
cmpadden 8158134
h2 border color keyline
cmpadden 8d436d1
add vscode recommendations;
PedramNavid f267e52
update data modeling
PedramNavid 985f583
add prelude/next-steps from templates
PedramNavid 18f065a
update sensor how-to
PedramNavid c0eb46a
refine asset sensors guide and improve TOC styling
PedramNavid 532cb5d
fix sidebar name
PedramNavid 2845f28
Merge branch 'pdrm/automation-part-2' into docs/revamp
PedramNavid 75b334e
[docs] [revamp] - Beefing up Vale (#23754)
erinkcochran87 137ed67
[docs] [revamp] - Vale updates (#23758)
erinkcochran87 3cd7383
[docs-beta] Use yarn
hellendag File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: Deploy Docs Revamp | ||
on: | ||
pull_request: | ||
paths: | ||
- docs/docs-beta | ||
- .github/workflows/build-docs-revamp.yml | ||
push: | ||
branches: | ||
- docs/revamp | ||
paths: | ||
- docs/docs-beta | ||
- .github/workflows/build-docs-revamp.yml | ||
|
||
concurrency: | ||
group: ${{ github.workflow}}-${{github.ref}} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
deploy: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout docs/revamp branch | ||
uses: actions/checkout@v4 | ||
|
||
- name: Publish Preview to Vercel | ||
uses: amondnet/vercel-action@v25 | ||
with: | ||
github-comment: ${{ true }} | ||
vercel-token: ${{ secrets.VERCEL_TOKEN }} | ||
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }} | ||
vercel-project-id: ${{ secrets.VERCEL_DOCS_NEXT_PROJECT_ID }} | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
scope: ${{ secrets.VERCEL_ORG_ID }} | ||
|
||
- name: Publish to Vercel Production | ||
uses: amondnet/vercel-action@v25 | ||
if: github.event_name == 'push' && github.ref == 'refs/heads/docs/revamp' | ||
with: | ||
vercel-token: ${{ secrets.VERCEL_TOKEN }} | ||
vercel-org-id: ${{ secrets.VERCEL_ORG_ID }} | ||
vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID }} | ||
vercel-args: "--prod" | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
scope: ${{ secrets.VERCEL_ORG_ID }} | ||
alias-domains: dagster-docs-beta.dagster.dagster-docs.io |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
name: Vale Docs | ||
on: | ||
pull_request: | ||
paths: | ||
- 'docs/**' | ||
- .github/workflows/vale.yml | ||
push: | ||
branches: | ||
- master | ||
- docs-prod | ||
paths: | ||
- 'docs/**' | ||
- .github/workflows/vale.yml | ||
|
||
concurrency: | ||
group: ${{ github.workflow}}-${{github.ref}} | ||
cancel-in-progress: true | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
vale: | ||
name: runner / vale | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: errata-ai/vale-action@reviewdog | ||
env: | ||
REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
files: '["docs-beta/docs"]' | ||
vale_flags: "--config=docs/.vale.ini" | ||
fail_on_error: true | ||
reporter: github-pr-check |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
sphinx/_build/ | ||
.env | ||
next/.env | ||
*.duckdb | ||
*.sqlite |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
######################## | ||
# ABOUT # | ||
######################## | ||
|
||
# This file controls the Vale application, specifically what, where, and how it lints. | ||
|
||
# Vale config reference: https://vale.sh/docs/topics/config | ||
# INI syntax: https://ini.unknwon.io/docs/intro | ||
|
||
######################## | ||
# CORE SETTINGS # | ||
######################## | ||
|
||
StylesPath = "vale/styles" | ||
MinAlertLevel = suggestion | ||
Vocab = Dagster | ||
|
||
######################## | ||
# FORMAT ASSOCIATIONS # | ||
######################## | ||
|
||
[formats] | ||
mdx = md | ||
|
||
######################## | ||
# FORMAT-SPECIFIC # | ||
######################## | ||
|
||
[*.{md,mdx,rst}] | ||
# Rules in this section are enforced in all md, mdx, and rst files | ||
|
||
[*.{md,mdx,rst}] | ||
BasedOnStyles = Dagster, Terms, Vale | ||
|
||
; Ignore all :py directives | ||
IgnorePatterns = (:py:[^`]+`[^`]+`) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
module.exports = { | ||
parser: '@babel/eslint-parser', | ||
extends: ['plugin:react/recommended', 'plugin:@docusaurus/recommended', 'plugin:mdx/recommended'], | ||
rules: { | ||
'import/no-default-export': 'off', | ||
'react/react-in-jsx-scope': 'off', | ||
}, | ||
ignorePatterns: ['build'], | ||
parserOptions: { | ||
extensions: ['.md', '.mdx'], // Resolve .md files as .mdx | ||
markdownExtensions: ['.md', '.markdown'], // Treat .md and .markdown files as plain markdown | ||
}, | ||
overrides: [ | ||
{ | ||
files: ['*.md', '*.mdx'], | ||
extends: 'plugin:mdx/recommended', | ||
rules: { | ||
'react/jsx-no-undef': 'off', | ||
'react/no-unescaped-entities': 'off', | ||
}, | ||
}, | ||
], | ||
settings: { | ||
react: { | ||
version: 'detect', | ||
}, | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Dependencies | ||
/node_modules | ||
|
||
# Production | ||
/build | ||
|
||
# Generated files | ||
.docusaurus | ||
.cache-loader | ||
|
||
# Misc | ||
.DS_Store | ||
.env.local | ||
.env.development.local | ||
.env.test.local | ||
.env.production.local | ||
|
||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
*.sqlite | ||
|
||
.pnp.* | ||
.yarn/* | ||
!.yarn/patches | ||
!.yarn/plugins | ||
!.yarn/releases | ||
!.yarn/sdks | ||
!.yarn/versions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
node_modules | ||
.docusaurus | ||
build/ | ||
docs/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
bracketSpacing: false, | ||
printWidth: 100, | ||
singleQuote: true, | ||
trailingComma: 'all', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = { | ||
plugins: ['remark-frontmatter'], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"recommendations": [ | ||
"dbaeumer.vscode-eslint", | ||
"unifiedjs.vscode-mdx", | ||
"esbenp.prettier-vscode", | ||
"mrmlnc.vscode-remark", | ||
"chrischinchilla.vale-vscode" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"editor.defaultFormatter": "esbenp.prettier-vscode" | ||
} |
Binary file not shown.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
nodeLinker: node-modules | ||
|
||
yarnPath: .yarn/releases/yarn-4.4.0.cjs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
# Dagster Docs - Beta | ||
|
||
This is the home of the new Dagster documentation. It is currently in beta and incomplete. | ||
The documentation site is built using [Docusaurus](https://docusaurus.io/), a modern static website generator. | ||
|
||
### Installation | ||
|
||
The site uses [yarn](https://yarnpkg.com/) for package management. Run `yarn install` to install dependencies. Note that the yarn binary is checked in, so you do not need to install yarn yourself. | ||
|
||
It also uses [vale](https://vale.sh/) to check for issues in the documentation. | ||
|
||
Install value with: | ||
|
||
```bash | ||
brew install vale | ||
``` | ||
|
||
### Overview of the docs | ||
|
||
Code in `./src` contains custom components, styles, themes, and layouts. | ||
Code `./content-templates` contains the templates for the documentation pages. | ||
Code in `./docs/` is the source of truth for the documentation. | ||
|
||
`./docs/code_examples` contains all code examples for the documentation. | ||
|
||
The docs are broken down into the following sections: | ||
|
||
- [Tutorials](./docs/tutorials/) | ||
- [Guides](./docs/guides/) | ||
- [Concepts](./docs/concepts/) | ||
|
||
`sidebar.ts` and `docusaurus.config.ts` are the main configuration files for the documentation. | ||
|
||
### Local Development | ||
|
||
To start the local development server: | ||
|
||
```bash | ||
yarn start | ||
``` | ||
|
||
This command starts a local development server and opens up a browser window. Most changes are reflected live without having to restart the server. Access the website at [http://localhost:3050](http://localhost:3050). | ||
|
||
To lint the documentation for issues: | ||
|
||
```bash | ||
yarn lint | ||
``` | ||
|
||
To autofix linting issues and format with prettier: | ||
|
||
```bash | ||
yarn lint:fix | ||
``` | ||
|
||
### Build | ||
|
||
To build the site for production: | ||
|
||
```bash | ||
yarn build | ||
``` | ||
|
||
This command generates static content into the `build` directory and can be served using any static contents hosting service. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = { | ||
presets: [require.resolve('@docusaurus/core/lib/babel/preset')], | ||
}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.