Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-beta] Add Vale updates #23785

Merged
merged 9 commits into from
Aug 21, 2024
Merged

[docs-beta] Add Vale updates #23785

merged 9 commits into from
Aug 21, 2024

Conversation

PedramNavid
Copy link
Contributor

Summary & Motivation

Brings in #23754 and #23758 into the master branch for docs-beta styling.

How I Tested These Changes

## Summary & Motivation

This PR beefs up our Vale implementation with some custom rules and
vocabularies. The README for this will be updated in a subsequent PR.

## How I Tested These Changes

eyes, local
## Summary & Motivation

This PR addresses comments in #23754 

## How I Tested These Changes
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

@PedramNavid PedramNavid force-pushed the docs/vale branch 2 times, most recently from ff9e8b1 to 972e9d1 Compare August 21, 2024 19:17
Copy link

Deploy preview for dagster-docs-beta ready!

✅ Preview
https://dagster-docs-beta-oe0stbdg3-elementl.vercel.app

Built with commit 26a8087.
This pull request is being automatically deployed with vercel-action

@PedramNavid PedramNavid merged commit a210af9 into master Aug 21, 2024
3 of 4 checks passed
@PedramNavid PedramNavid deleted the docs/vale branch August 21, 2024 20:25
PedramNavid added a commit that referenced this pull request Aug 21, 2024
Brings in #23754 and #23758 into the master branch for docs-beta
styling.

---------

Co-authored-by: Erin Cochran <[email protected]>
sryza pushed a commit that referenced this pull request Aug 24, 2024
## Summary & Motivation

Brings in #23754 and #23758 into the master branch for docs-beta
styling.

## How I Tested These Changes

---------

Co-authored-by: Erin Cochran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants