-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-beta] Add Vale updates #23785
Merged
Merged
[docs-beta] Add Vale updates #23785
+35,410
−15,004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary & Motivation This PR beefs up our Vale implementation with some custom rules and vocabularies. The README for this will be updated in a subsequent PR. ## How I Tested These Changes eyes, local
## Summary & Motivation This PR addresses comments in #23754 ## How I Tested These Changes
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-4jcimy1xx-elementl.vercel.app Direct link to changed pages: |
erinkcochran87
approved these changes
Aug 21, 2024
PedramNavid
force-pushed
the
docs/vale
branch
2 times, most recently
from
August 21, 2024 19:17
ff9e8b1
to
972e9d1
Compare
Deploy preview for dagster-docs-beta ready! ✅ Preview Built with commit 26a8087. |
PedramNavid
added a commit
that referenced
this pull request
Aug 21, 2024
Brings in #23754 and #23758 into the master branch for docs-beta styling. --------- Co-authored-by: Erin Cochran <[email protected]>
sryza
pushed a commit
that referenced
this pull request
Aug 24, 2024
## Summary & Motivation Brings in #23754 and #23758 into the master branch for docs-beta styling. ## How I Tested These Changes --------- Co-authored-by: Erin Cochran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Brings in #23754 and #23758 into the master branch for docs-beta styling.
How I Tested These Changes