[docathon] Configuring assets guide #23924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
requested review from
erinkcochran87,
PedramNavid and
cmpadden
Graphite Automations"docs-beta - Assign Reviewers" took an action on this PR • (08/26/24)3 reviewers were added to this PR based on Pedram Navid's automation. |
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-f73hns305-elementl.vercel.app Direct link to changed pages: |
cmpadden
reviewed
Aug 26, 2024
...cs_beta_snippets/docs_beta_snippets/guides/data-modeling/configuring-assets/config-schema.py
Outdated
Show resolved
Hide resolved
PedramNavid
reviewed
Aug 26, 2024
...cs_beta_snippets/docs_beta_snippets/guides/data-modeling/configuring-assets/config-schema.py
Outdated
Show resolved
Hide resolved
sryza
reviewed
Aug 26, 2024
sryza
reviewed
Aug 26, 2024
Co-authored-by: Sandy Ryza <[email protected]>
Co-authored-by: Pedram Navid <[email protected]>
|
I think this is ready to land |
cmpadden
approved these changes
Aug 27, 2024
cmpadden
pushed a commit
that referenced
this pull request
Aug 27, 2024
## Summary & Motivation This is a quick followup to [this PR](#23924) on asset configuration. I wanted to make it super clear that the point of asset config is runtime configuration, because this has been a source of confusion in the past which makes it more difficult to explain asset factories. Also incorporated @erinkcochran87's feedback here: #23924 (comment). ## How I Tested These Changes ## Changelog [New | Bug | Docs] NOCHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
First pass at a short-but-sweet asset config guide.
How I Tested These Changes
Changelog [New | Bug | Docs]
NOCHANGELOG