Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc 302 new etl tutorial - part 1 #25320
base: master
Are you sure you want to change the base?
Doc 302 new etl tutorial - part 1 #25320
Changes from 16 commits
c275842
054141c
89be27a
59f5a64
bf7b65b
d6d69cf
19d3236
9b8bdc2
6f078db
8b6d1f6
8ef90cf
2425783
49035dd
17aff77
75e60fe
d4ff6d3
b30f860
140a122
f29065e
130b418
d34c41b
62e5fd0
aae8195
1eb255c
4148df7
aee2029
5db379b
6974fcb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 81 in docs/docs-beta/docs/tutorial/01-etl-tutorial-introduction.md
GitHub Actions / runner / vale
Check warning on line 105 in docs/docs-beta/docs/tutorial/01-etl-tutorial-introduction.md
GitHub Actions / runner / vale
Check warning on line 112 in docs/docs-beta/docs/tutorial/01-etl-tutorial-introduction.md
GitHub Actions / runner / vale
Check failure on line 121 in docs/docs-beta/docs/tutorial/01-etl-tutorial-introduction.md
GitHub Actions / runner / vale
Check failure on line 121 in docs/docs-beta/docs/tutorial/01-etl-tutorial-introduction.md
GitHub Actions / runner / vale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rephrase this a bit to tighten things up and provide a motivation for this section with something like:
"To make sure Dagster and its dependencies were installed correctly, navigate to the project root directory and start the Dagster webserver:"
followed by a bash code snippet for
dagster dev
(so it can be copy/pasted).Check warning on line 83 in docs/docs-beta/docs/tutorial/02-create-and-materialize-assets.md
GitHub Actions / runner / vale
This file was deleted.